fix: Correct missing database error

Author: jhnsmth

bins/tdb/interactive.rs

@@ -118,7 +118,7 @@ pub fn run(cli: &mut TectonicClient) -> io::Result<()> {
             _ => {
                 match cli.cmd(&line) {
                     Err(e) => {
-                        println!("{}", e.description());
+                        println!("{}", e);
                     }
                     Ok(msg) => {
                         println!("{}", msg);

crates/tdb-cli/src/client.rs

@@ -74,8 +74,8 @@ impl TectonicClient {
             let res = std::str::from_utf8(&buf).unwrap().to_owned();
             if success {
                 Ok(res)
-            } else if res.contains("ERR: DB") {
-                let book_name = res.split(" ").nth(2).unwrap();
+            } else if res.starts_with("ERR: No db named") {
+                let book_name = res.split(" ").nth(4).unwrap();
                 Err(TectonicError::DBNotFoundError(book_name.to_owned()))
             } else  {
                 Err(TectonicError::ServerError(res))

crates/tdb-server-core/src/handler.rs

@@ -29,6 +29,11 @@ impl ReturnType {
     {
         ReturnType::Error(string.into())
     }
+
+    pub fn missing_db(db_name: &BookName) -> ReturnType {
+        //NB On change update match in client as well
+        ReturnType::error(format!("No db named {}", db_name))
+    }
 }
 
 
@@ -226,7 +231,7 @@ mod tests {
             addr
         ));
         assert_eq!(
-            ReturnType::Error("DB bnc_btc_eth not found.".into()),
+            ReturnType::Error("No db named bnc_btc_eth".into()),
             resp
         );
     }

crates/tdb-server-core/src/state.rs

@@ -272,17 +272,19 @@ impl TectonicServer {
                     .unwrap_or_else(|| Arc::clone(&self.conn(addr).unwrap().book_entry));
                 match self.insert(up, &book_name).await {
                     Some(()) => ReturnType::string(""),
-                    None => ReturnType::Error(Cow::Owned(format!("DB {} not found.", &book_name))),
+                    None => ReturnType::missing_db(&book_name),
                 }
             }
             Insert(None, _) => ReturnType::error("Unable to parse line"),
-            Create(dbname) => match self.create(&dbname) {
+            Create(dbname) => {
+                match self.create(&dbname) {
                     Some(()) => ReturnType::string(format!("Created orderbook `{}`.", &dbname)),
                     None => ReturnType::error(format!("Unable to create orderbook `{}`.", &dbname)),
-                },
+                }
+            }
             Subscribe(dbname) => {
                 self.sub(&dbname, addr);
-                ReturnType::string(format!("Subscribed to {}", dbname))
+                ReturnType::string(format!("Subscribed to {}", &dbname))
             }
             // Subscription => {
             //     let message = state.rx.as_ref().unwrap().try_recv();
@@ -303,20 +305,20 @@ impl TectonicServer {
             Load(dbname) => {
                 match self.load_db(&dbname, addr) {
                     Some(_) => ReturnType::string(format!("Loaded orderbook `{}`.", &dbname)),
-                    None => ReturnType::error(format!("No db named `{}`", dbname)),
+                    None => ReturnType::missing_db(&dbname),
                 }
             }
             Use(dbname) => {
                 match self.use_db(&dbname, addr) {
                     Some(_) => ReturnType::string(format!("SWITCHED TO orderbook `{}`.", &dbname)),
-                    None => ReturnType::error(format!("No db named `{}`", dbname)),
+                    None => ReturnType::missing_db(&dbname),
                 }
             }
             Exists(dbname) => {
                 if self.exists(&dbname) {
                     ReturnType::ok()
                 } else {
-                    ReturnType::error(format!("No db named `{}`", dbname))
+                    ReturnType::missing_db(&dbname)
                 }
             }
             Get(cnt, fmt, rng, loc) =>