-
Notifications
You must be signed in to change notification settings - Fork 13
Open
Description
Describe the bug
When implementing multiple instances of the Navigation component on the same page, duplicate IDs will be present in the DOM, leading to validation/a11y errors. https://github.com/10up/component-library/blob/develop/packages/navigation/src/navigation.js#L205 uses the loop's index to set the ID.
To Reproduce
Steps to reproduce the behavior:
- Instantiate multiple navigation components on the same page
- Inspect the submenu IDs, e.g. "tenUp-submenu-0"
Expected behavior
The unique IDs should be generated using the uuid package or the window.crypto.randomUUID() method, or the Navigation class should allow passing in an ID prefix.
Additional context
My use case: I'm using the Navigation component for the main/primary navigation, as well as for navigation blocks in the editor.
Metadata
Metadata
Assignees
Labels
No labels