Skip to content

[DEVOPS-2250] move proxy.licenseKey to secret #830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

[DEVOPS-2250] move proxy.licenseKey to secret #830

wants to merge 1 commit into from

Conversation

@SanchezzRU
Copy link
Contributor

@SanchezzRU SanchezzRU commented Nov 21, 2025 •
edited
Loading

Pull Request description

Changelog

  • Вынес proxy.licenseKey в секрет
  • Поправил отступы/форматирование

Issues

Breaking changes

Check-list. Чек-лист код-ревью

  • Запрос на слияние в develop.
  • Есть описание к PR.
  • Указаны блокирующие изменения. Breaking-Changes
  • Соответствие кода принятому стилю
    • Описание настроек.
    • Именование настроек.
    • Дефолтные значения.
    • Стиль кода.
  • Работоспособность. Разворачивается на своем окружении из ветки PR.
    • Тест API через тесты helmfile-хуков или коллекций Postman.
  • Не осталось мусора от удаления каких-то параметров. Ищется поиском по проекту из ветки PR.
  • Отработка линтера на чарт из ветки PR. Пример: helm lint charts/search-api

@SanchezzRU SanchezzRU requested review from a team as code owners November 21, 2025 07:33
@SanchezzRU SanchezzRU force-pushed the fb/DEVOPS-2250-traffic-proxy-secret branch from b26d272 to abbc234 Compare November 21, 2025 07:37
@SanchezzRU SanchezzRU marked this pull request as draft November 21, 2025 07:38
@SanchezzRU SanchezzRU force-pushed the fb/DEVOPS-2250-traffic-proxy-secret branch 2 times, most recently from c5a6949 to 55d4c0c Compare November 21, 2025 08:23
@SanchezzRU SanchezzRU changed the title [DEVOPS-2250] move proxy.apiKey to secret [DEVOPS-2250] move proxy.licenseKey to secret Nov 21, 2025
@SanchezzRU SanchezzRU force-pushed the fb/DEVOPS-2250-traffic-proxy-secret branch from 66dad89 to dc79c56 Compare November 21, 2025 10:11
@SanchezzRU SanchezzRU marked this pull request as ready for review November 21, 2025 10:18
@SergeyKodolov
Copy link
Collaborator

SergeyKodolov commented Nov 24, 2025

Задача на проверку PR https://jira.2gis.ru/browse/ONPREM-2717

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SanchezzRU @SergeyKodolov