Only pop a marker if we have an earlier push

solidpixel · solidpixel · commit cd3ada7ccfce · 2025-10-16T13:33:38.000+01:00
diff --git a/source_common/trackers/queue.cpp b/source_common/trackers/queue.cpp
@@ -76,7 +76,12 @@ namespace
         {
             UNUSED(instruction);
 
-            queueState.debugStack.pop_back();
+            // Only pop if we have an earlier push - this shouldn't happen and
+            // is a validation violation, but not all apps handle this correctly
+            if (!queueState.debugStack.empty())
+            {
+                queueState.debugStack.pop_back();
+            }
         }
 
         /**

Original file line number	Diff line number	Diff line change
`@@ -76,7 +76,12 @@ namespace`
`76`	`76`	`{`
`77`	`77`	`UNUSED(instruction);`
`78`	`78`
`79`		`- queueState.debugStack.pop_back();`
	`79`	`+ // Only pop if we have an earlier push - this shouldn't happen and`
	`80`	`+ // is a validation violation, but not all apps handle this correctly`
	`81`	`+ if (!queueState.debugStack.empty())`
	`82`	`+ {`
	`83`	`+ queueState.debugStack.pop_back();`
	`84`	`+ }`
`80`	`85`	`}`
`81`	`86`
`82`	`87`	`/**`