Skip to content

Commit 4842e91

Browse files
committed
Disabling group properties being updated due to an API bug whereby it thinks the default visibility level should be applied even though it's not specified in the API call.
Confirmed bug: https://gitlab.com/gitlab-org/gitlab-ce/issues/48764
1 parent b2979db commit 4842e91

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

src/LdapSyncCommand.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1305,12 +1305,14 @@ private function deployGitlabUsersAndGroups(array $config, string $gitlabInstanc
13051305
}
13061306
$ldapGroupMembers = $ldapGroupsSafe[$gitlabGroupName];
13071307

1308+
/*
13081309
!$this->dryRun ? ($gitlabGroup = $gitlab->api("groups")->update($gitlabGroupId, [
13091310
// "name" => $gitlabGroupName,
13101311
// No point updating that. ^
13111312
// If the CN changes so will that bit of the DN anyway, so this can't be detected with a custom attribute containing the Gitlab group ID written back to group's LDAP object.
13121313
"path" => $gitlabGroupPath,
13131314
])) : $this->logger->warning("Operation skipped due to dry run.");
1315+
*/
13141316

13151317
$groupsSync["update"][$gitlabGroupId] = $gitlabGroupName;
13161318
}

0 commit comments

Comments
 (0)