Use Compiler Metrics to make Composables skippable

AfzalivE · AfzalivE · commit 28649159c830 · 2022-08-13T23:40:18.000-04:00
diff --git a/mobile/build.gradle b/mobile/build.gradle
@@ -4,12 +4,12 @@ plugins {
 }
 
 android {
-    compileSdk 32
+    compileSdk 33
 
     defaultConfig {
         applicationId "com.afzaln.besttvlauncher"
         minSdk 29
-        targetSdk 32
+        targetSdk 33
         versionCode 1
         versionName "1.0"
 
diff --git a/tv/build.gradle b/tv/build.gradle
@@ -54,6 +54,19 @@ android {
     kotlinOptions {
         jvmTarget = "1.8"
         freeCompilerArgs += ["-Xjvm-default=enable"]
+
+        if (project.findProperty("com.afzaln.besttvlauncher.enableComposeCompilerReports") == "true") {
+            freeCompilerArgs += [
+                    "-P",
+                    "plugin:androidx.compose.compiler.plugins.kotlin:reportsDestination=" +
+                            project.buildDir.absolutePath + "/compose_metrics"
+            ]
+            freeCompilerArgs += [
+                    "-P",
+                    "plugin:androidx.compose.compiler.plugins.kotlin:metricsDestination=" +
+                            project.buildDir.absolutePath + "/compose_metrics"
+            ]
+        }
     }
 
     buildFeatures {
@@ -83,6 +96,7 @@ android {
 }
 
 dependencies {
+    implementation("org.jetbrains.kotlinx:kotlinx-collections-immutable:0.3.5")
 
     implementation("androidx.core:core-ktx:1.8.0")
     implementation("androidx.leanback:leanback:1.0.0")
diff --git a/tv/src/main/java/com/afzaln/besttvlauncher/data/AppInfoRepository.kt b/tv/src/main/java/com/afzaln/besttvlauncher/data/AppInfoRepository.kt
@@ -3,6 +3,10 @@ package com.afzaln.besttvlauncher.data
 import android.content.Context
 import android.content.Intent
 import android.content.pm.PackageManager
+import com.afzaln.besttvlauncher.data.models.AppInfo
+import kotlinx.collections.immutable.ImmutableList
+import kotlinx.collections.immutable.persistentListOf
+import kotlinx.collections.immutable.toImmutableList
 import kotlinx.coroutines.Dispatchers
 import kotlinx.coroutines.flow.Flow
 import kotlinx.coroutines.flow.flow
@@ -12,8 +16,8 @@ import kotlinx.coroutines.withContext
 class AppInfoRepository(private val context: Context) {
     private val packageManager: PackageManager = context.packageManager
 
-    private var cached: List<AppInfo> = listOf()
-    val apps: Flow<List<AppInfo>> = flow {
+    private var cached: ImmutableList<AppInfo> = persistentListOf()
+    val apps: Flow<ImmutableList<AppInfo>> = flow {
         emit(cached)
         val newList = loadAppInfo()
         if (cached != newList) {
@@ -22,7 +26,7 @@ class AppInfoRepository(private val context: Context) {
         }
     }.flowOn(Dispatchers.IO)
 
-    private suspend fun loadAppInfo(): List<AppInfo> = withContext(Dispatchers.IO) {
+    private suspend fun loadAppInfo(): ImmutableList<AppInfo> = withContext(Dispatchers.IO) {
         val intent = Intent(Intent.ACTION_MAIN, null).apply {
             addCategory(Intent.CATEGORY_LEANBACK_LAUNCHER)
         }
@@ -34,10 +38,10 @@ class AppInfoRepository(private val context: Context) {
             .distinctBy { it.activityInfo.packageName + it.activityInfo.name.split(".").last() }
             .map { app ->
                 AppInfo(
-                    app.loadLabel(packageManager),
+                    app.loadLabel(packageManager).toString(),
                     app.activityInfo.packageName,
                     app.activityInfo.loadBanner(packageManager)
                 )
-            }
+            }.toImmutableList()
     }
 }
diff --git a/tv/src/main/java/com/afzaln/besttvlauncher/data/ChannelRepository.kt b/tv/src/main/java/com/afzaln/besttvlauncher/data/ChannelRepository.kt
@@ -3,7 +3,14 @@ package com.afzaln.besttvlauncher.data
 import android.annotation.SuppressLint
 import android.content.Context
 import android.content.pm.PackageManager
-import androidx.tvprovider.media.tv.*
+import androidx.tvprovider.media.tv.PreviewChannelHelper
+import androidx.tvprovider.media.tv.PreviewProgram
+import androidx.tvprovider.media.tv.PreviewProgramHelper
+import androidx.tvprovider.media.tv.TvContractCompat
+import com.afzaln.besttvlauncher.data.models.Channel
+import com.afzaln.besttvlauncher.data.models.Program
+import com.afzaln.besttvlauncher.data.models.toProgram
+import kotlinx.collections.immutable.*
 import kotlinx.coroutines.Dispatchers
 import kotlinx.coroutines.flow.MutableStateFlow
 import kotlinx.coroutines.flow.asStateFlow
@@ -16,10 +23,12 @@ class ChannelRepository(context: Context) {
     private val previewProgramHelper: PreviewProgramHelper = PreviewProgramHelper(context)
     private val packageManager: PackageManager = context.packageManager
 
-    private var _cachedMap = MutableStateFlow<Map<PreviewChannel, List<PreviewProgram>>>(mapOf())
+    private var _cachedMap = MutableStateFlow<ImmutableMap<Channel, ImmutableList<Program>>>(
+        persistentMapOf()
+    )
     val channelProgramMap = _cachedMap.asStateFlow()
 
-    private val _channels = MutableStateFlow<List<PreviewChannelWrapper>>(listOf())
+    private val _channels = MutableStateFlow<ImmutableList<Channel>>(persistentListOf())
     val channels = _channels.asStateFlow()
 
     suspend fun refreshData() {
@@ -32,13 +41,12 @@ class ChannelRepository(context: Context) {
 
     @SuppressLint("RestrictedApi")
     private suspend fun loadPrograms(
-        channelList: List<PreviewChannelWrapper>,
-        initial: Map<PreviewChannel, List<PreviewProgram>>
-    ): Map<PreviewChannel, List<PreviewProgram>> = withContext(Dispatchers.IO) {
+        channelList: ImmutableList<Channel>,
+        initial: ImmutableMap<Channel, ImmutableList<Program>>
+    ): ImmutableMap<Channel, ImmutableList<Program>> = withContext(Dispatchers.IO) {
         initial.toMutableMap().apply {
-            channelList.forEach { wrappedChannel ->
+            channelList.forEach { channel ->
                 logcat { "LoadPrograms: ${Thread.currentThread().name}" }
-                val channel = wrappedChannel.channel
                 val programs = if (isWrongAspectRatio(channel)) {
                     previewProgramHelper.getAllProgramsInChannel(channel.id).map { program ->
                         PreviewProgram.Builder(program)
@@ -49,17 +57,19 @@ class ChannelRepository(context: Context) {
                     }
                 } else {
                     previewProgramHelper.getAllProgramsInChannel(channel.id)
-                }
+                }.map { program ->
+                    program.toProgram()
+                }.toImmutableList()
                 put(channel, programs)
             }
-        }
+        }.toImmutableMap()
     }
 
     /**
      * To compensate for YouTube Recommended, Music,
      * and Trending art ratios including black bars.
      */
-    private fun isWrongAspectRatio(channel: PreviewChannel) =
+    private fun isWrongAspectRatio(channel: Channel) =
         channel.packageName == "com.google.android.youtube.tv" &&
                 !channel.displayName.contentEquals("Free movies from Youtube", true)
 
@@ -70,11 +80,13 @@ class ChannelRepository(context: Context) {
                 return@update previewChannelHelper.allChannels.map { previewChannel ->
                     logcat { "LoadChannels: ${Thread.currentThread().name}" }
                     val appInfo = packageManager.getApplicationInfo(previewChannel.packageName, 0)
-                    PreviewChannelWrapper(
-                        previewChannel,
+                    Channel(
+                        previewChannel.id,
+                        previewChannel.displayName.toString(),
+                        previewChannel.packageName,
                         appInfo.loadLabel(packageManager).toString()
                     )
-                }
+                }.toImmutableList()
             }
         }
     }
diff --git a/tv/src/main/java/com/afzaln/besttvlauncher/data/PreviewChannelWrapper.kt b/tv/src/main/java/com/afzaln/besttvlauncher/data/PreviewChannelWrapper.kt
diff --git a/tv/src/main/java/com/afzaln/besttvlauncher/data/ProgramRepository.kt b/tv/src/main/java/com/afzaln/besttvlauncher/data/ProgramRepository.kt
@@ -1,8 +1,12 @@
 package com.afzaln.besttvlauncher.data
 
 import android.content.Context
-import androidx.tvprovider.media.tv.WatchNextProgram
 import androidx.tvprovider.media.tv.WatchNextProgramHelper
+import com.afzaln.besttvlauncher.data.models.Program
+import com.afzaln.besttvlauncher.data.models.toProgram
+import kotlinx.collections.immutable.ImmutableList
+import kotlinx.collections.immutable.persistentListOf
+import kotlinx.collections.immutable.toImmutableList
 import kotlinx.coroutines.Dispatchers
 import kotlinx.coroutines.flow.MutableStateFlow
 import kotlinx.coroutines.flow.asStateFlow
@@ -12,7 +16,7 @@ import kotlinx.coroutines.withContext
 class ProgramRepository(context: Context) {
     private val watchNextProgramHelper = WatchNextProgramHelper(context)
 
-    private val _watchNextPrograms = MutableStateFlow<List<WatchNextProgram>>(listOf())
+    private val _watchNextPrograms = MutableStateFlow<ImmutableList<Program>>(persistentListOf())
     val watchNextPrograms = _watchNextPrograms.asStateFlow()
 
     suspend fun refreshData() {
@@ -22,7 +26,9 @@ class ProgramRepository(context: Context) {
     // TODO observe ContentProvider using ContentResolver.registerContentObserver
     private suspend fun loadWatchNextPrograms() = withContext(Dispatchers.IO) {
         _watchNextPrograms.update {
-            watchNextProgramHelper.allWatchNextPrograms
+            watchNextProgramHelper.allWatchNextPrograms.map { program ->
+                program.toProgram()
+            }.toImmutableList()
         }
     }
 }
diff --git a/tv/src/main/java/com/afzaln/besttvlauncher/data/models/AppInfo.kt b/tv/src/main/java/com/afzaln/besttvlauncher/data/models/AppInfo.kt
@@ -1,11 +1,11 @@
-package com.afzaln.besttvlauncher.data
+package com.afzaln.besttvlauncher.data.models
 
 import android.content.Context
 import android.content.Intent
 import android.graphics.drawable.Drawable
 
 data class AppInfo(
-    val label: CharSequence,
+    val label: String,
     val packageName: String,
     val banner: Drawable
 )
diff --git a/tv/src/main/java/com/afzaln/besttvlauncher/data/models/Channel.kt b/tv/src/main/java/com/afzaln/besttvlauncher/data/models/Channel.kt
@@ -0,0 +1,8 @@
+package com.afzaln.besttvlauncher.data.models
+
+data class Channel(
+    val id: Long,
+    val displayName: String,
+    val packageName: String,
+    val appName: String
+)
diff --git a/tv/src/main/java/com/afzaln/besttvlauncher/data/models/Program.kt b/tv/src/main/java/com/afzaln/besttvlauncher/data/models/Program.kt
@@ -1,11 +1,33 @@
-package com.afzaln.besttvlauncher.utils
+package com.afzaln.besttvlauncher.data.models
 
 import android.annotation.SuppressLint
 import androidx.tvprovider.media.tv.BasePreviewProgram
 import androidx.tvprovider.media.tv.TvContractCompat
 
+data class Program(
+    val id: Long,
+    val title: String,
+    val description: String,
+    val genre: String?,
+    val releaseDate: String?,
+    val durationMillis: Int,
+    val posterArtAspectRatio: Int,
+    val posterArtUri: String,
+)
+
+fun BasePreviewProgram.toProgram() = Program(
+    id,
+    title,
+    description,
+    genre,
+    releaseDate,
+    durationMillis,
+    posterArtAspectRatio,
+    posterArtUri.toString(),
+)
+
 @SuppressLint("RestrictedApi")
-fun BasePreviewProgram.posterAspectRatio(): Float = when (posterArtAspectRatio) {
+fun Program.posterAspectRatio(): Float = when (posterArtAspectRatio) {
     // TODO publish AndroidTvProvider fork 1.0.2
     TvContractCompat.PreviewProgramColumns.ASPECT_RATIO_16_9 -> 16f / 9
     TvContractCompat.PreviewProgramColumns.ASPECT_RATIO_3_2 -> 3f / 2
diff --git a/tv/src/main/java/com/afzaln/besttvlauncher/ui/apps/AppsScreen.kt b/tv/src/main/java/com/afzaln/besttvlauncher/ui/apps/AppsScreen.kt
@@ -24,10 +24,11 @@ import androidx.compose.ui.unit.dp
 import androidx.core.graphics.drawable.toBitmap
 import androidx.tv.foundation.lazy.grid.*
 import com.afzaln.besttvlauncher.R
-import com.afzaln.besttvlauncher.data.AppInfo
-import com.afzaln.besttvlauncher.data.getLaunchIntent
+import com.afzaln.besttvlauncher.data.models.AppInfo
+import com.afzaln.besttvlauncher.data.models.getLaunchIntent
 import com.afzaln.besttvlauncher.ui.theme.AppTheme
 import com.afzaln.besttvlauncher.utils.dpadFocusable
+import kotlinx.collections.immutable.ImmutableList
 
 @Composable
 fun AppsScreen(state: HomeViewModel.State) {
@@ -41,7 +42,7 @@ fun AppsScreen(state: HomeViewModel.State) {
 
 @OptIn(ExperimentalFoundationApi::class)
 @Composable
-fun AppList(appList: List<AppInfo>) {
+fun AppList(appList: ImmutableList<AppInfo>) {
     val gridState = rememberTvLazyGridState()
     val relocationRequester = remember { BringIntoViewRequester() }
 
diff --git a/tv/src/main/java/com/afzaln/besttvlauncher/ui/apps/HomeViewModel.kt b/tv/src/main/java/com/afzaln/besttvlauncher/ui/apps/HomeViewModel.kt
@@ -3,10 +3,15 @@ package com.afzaln.besttvlauncher.ui.apps
 import androidx.compose.ui.graphics.Color
 import androidx.lifecycle.*
 import androidx.palette.graphics.Palette
-import androidx.tvprovider.media.tv.PreviewChannel
-import androidx.tvprovider.media.tv.PreviewProgram
-import androidx.tvprovider.media.tv.WatchNextProgram
-import com.afzaln.besttvlauncher.data.*
+import com.afzaln.besttvlauncher.data.AppInfoRepository
+import com.afzaln.besttvlauncher.data.ChannelRepository
+import com.afzaln.besttvlauncher.data.ProgramRepository
+import com.afzaln.besttvlauncher.data.UserPreferences
+import com.afzaln.besttvlauncher.data.models.AppInfo
+import com.afzaln.besttvlauncher.data.models.Channel
+import com.afzaln.besttvlauncher.data.models.Program
+import kotlinx.collections.immutable.ImmutableList
+import kotlinx.collections.immutable.ImmutableMap
 import kotlinx.coroutines.delay
 import kotlinx.coroutines.flow.combine
 import kotlinx.coroutines.launch
@@ -54,9 +59,9 @@ class HomeViewModel(
     sealed class State {
         object Loading : State()
         class Loaded(
-            val programsByChannel: Map<PreviewChannel, List<PreviewProgram>>,
-            val watchNextPrograms: List<WatchNextProgram>,
-            val appInfoList: List<AppInfo>
+            val programsByChannel: ImmutableMap<Channel, ImmutableList<Program>>,
+            val watchNextPrograms: ImmutableList<Program>,
+            val appInfoList: ImmutableList<AppInfo>
         ) : State()
     }
 }
diff --git a/tv/src/main/java/com/afzaln/besttvlauncher/ui/channels/ChannelsScreen.kt b/tv/src/main/java/com/afzaln/besttvlauncher/ui/channels/ChannelsScreen.kt
diff --git a/tv/src/main/java/com/afzaln/besttvlauncher/ui/itemdetails/ItemDetailsScreen.kt b/tv/src/main/java/com/afzaln/besttvlauncher/ui/itemdetails/ItemDetailsScreen.kt
diff --git a/tv/src/main/java/com/afzaln/besttvlauncher/ui/settings/SettingsContainerFragment.kt b/tv/src/main/java/com/afzaln/besttvlauncher/ui/settings/SettingsContainerFragment.kt
diff --git a/tv/src/main/java/com/afzaln/besttvlauncher/utils/RecomposeHighlighter.kt b/tv/src/main/java/com/afzaln/besttvlauncher/utils/RecomposeHighlighter.kt
