fix(cli): add @cloudflare/workers-types in root instead of packages when alchemy deploy

Author: AmanVarshney01

apps/cli/src/helpers/deployment/server-deploy-setup.ts

@@ -117,15 +117,8 @@ export async function setupAlchemyServerDeploy(
 }
 
 async function addAlchemyPackagesDependencies(projectDir: string) {
-	const packages = ["packages/api", "packages/auth", "packages/db"];
-
-	for (const packageName of packages) {
-		const packageDir = path.join(projectDir, packageName);
-		if (await fs.pathExists(packageDir)) {
-			await addPackageDependency({
-				devDependencies: ["@cloudflare/workers-types"],
-				projectDir: packageDir,
-			});
-		}
-	}
+	await addPackageDependency({
+		devDependencies: ["@cloudflare/workers-types"],
+		projectDir,
+	});
 }

apps/cli/src/helpers/deployment/web-deploy-setup.ts

@@ -98,15 +98,8 @@ async function setupWorkersWebDeploy(
 }
 
 async function addAlchemyPackagesDependencies(projectDir: string) {
-	const packages = ["packages/api", "packages/auth", "packages/db"];
-
-	for (const packageName of packages) {
-		const packageDir = path.join(projectDir, packageName);
-		if (await fs.pathExists(packageDir)) {
-			await addPackageDependency({
-				devDependencies: ["@cloudflare/workers-types"],
-				projectDir: packageDir,
-			});
-		}
-	}
+	await addPackageDependency({
+		devDependencies: ["@cloudflare/workers-types"],
+		projectDir,
+	});
 }

apps/cli/src/utils/config-validation.ts

@@ -446,6 +446,16 @@ export function validateFullConfig(
 		);
 	}
 
+	if (
+		providedFlags.has("serverDeploy") &&
+		(config.serverDeploy === "alchemy" || config.serverDeploy === "wrangler") &&
+		config.runtime !== "workers"
+	) {
+		exitWithError(
+			`Server deployment '${config.serverDeploy}' requires '--runtime workers'. Please use '--runtime workers' or choose a different server deployment.`,
+		);
+	}
+
 	if (config.addons && config.addons.length > 0) {
 		validateAddonsAgainstFrontends(config.addons, config.frontend, config.auth);
 		config.addons = [...new Set(config.addons)];

apps/cli/templates/deploy/alchemy/alchemy.run.ts.hbs

@@ -59,7 +59,7 @@ export const web = await Nextjs("web", {
   bindings: {
     {{#if (eq backend "convex")}}
     NEXT_PUBLIC_CONVEX_URL: process.env.NEXT_PUBLIC_CONVEX_URL || "",
-    {{else}}
+    {{else if (ne backend "self")}}
     NEXT_PUBLIC_SERVER_URL: process.env.NEXT_PUBLIC_SERVER_URL || "",
     {{/if}}
   },
@@ -73,7 +73,7 @@ export const web = await Nuxt("web", {
   bindings: {
     {{#if (eq backend "convex")}}
     NUXT_PUBLIC_CONVEX_URL: process.env.NUXT_PUBLIC_CONVEX_URL || "",
-    {{else}}
+    {{else if (ne backend "self")}}
     NUXT_PUBLIC_SERVER_URL: process.env.NUXT_PUBLIC_SERVER_URL || "",
     {{/if}}
   },
@@ -87,7 +87,7 @@ export const web = await SvelteKit("web", {
   bindings: {
     {{#if (eq backend "convex")}}
     PUBLIC_CONVEX_URL: process.env.PUBLIC_CONVEX_URL || "",
-    {{else}}
+    {{else if (ne backend "self")}}
     PUBLIC_SERVER_URL: process.env.PUBLIC_SERVER_URL || "",
     {{/if}}
   },
@@ -101,7 +101,7 @@ export const web = await TanStackStart("web", {
   bindings: {
     {{#if (eq backend "convex")}}
     VITE_CONVEX_URL: process.env.VITE_CONVEX_URL || "",
-    {{else}}
+    {{else if (ne backend "self")}}
     VITE_SERVER_URL: process.env.VITE_SERVER_URL || "",
     {{/if}}
   },
@@ -116,7 +116,7 @@ export const web = await Vite("web", {
   bindings: {
     {{#if (eq backend "convex")}}
     VITE_CONVEX_URL: process.env.VITE_CONVEX_URL || "",
-    {{else}}
+    {{else if (ne backend "self")}}
     VITE_SERVER_URL: process.env.VITE_SERVER_URL || "",
     {{/if}}
   },
@@ -130,7 +130,7 @@ export const web = await ReactRouter("web", {
   bindings: {
     {{#if (eq backend "convex")}}
     VITE_CONVEX_URL: process.env.VITE_CONVEX_URL || "",
-    {{else}}
+    {{else if (ne backend "self")}}
     VITE_SERVER_URL: process.env.VITE_SERVER_URL || "",
     {{/if}}
   },
@@ -145,7 +145,7 @@ export const web = await Vite("web", {
   bindings: {
     {{#if (eq backend "convex")}}
     VITE_CONVEX_URL: process.env.VITE_CONVEX_URL || "",
-    {{else}}
+    {{else if (ne backend "self")}}
     VITE_SERVER_URL: process.env.VITE_SERVER_URL || "",
     {{/if}}
   },

apps/web/src/app/(home)/_components/stats-section.tsx

@@ -23,8 +23,7 @@ export default function StatsSection({
 		lastUpdated: string | null;
 	};
 }) {
-
-	// no idea why there are no types 
+	// no idea why there are no types
 	// eslint-disable-next-line @typescript-eslint/no-explicit-any
 	const githubRepo = useQuery((api as any).stats.getGithubRepo, {
 		name: "AmanVarshney01/create-better-t-stack",
@@ -192,8 +191,10 @@ export default function StatsSection({
 							<span className="font-mono text-foreground text-sm">
 								{npmPackages?.dayOfWeekAverages
 									? Math.round(
-											npmPackages.dayOfWeekAverages.reduce((a: number, b: number) => a + b, 0) /
-												7,
+											npmPackages.dayOfWeekAverages.reduce(
+												(a: number, b: number) => a + b,
+												0,
+											) / 7,
 										)
 									: "—"}
 							</span>