Skip to content

Commit e788c71

Browse files
authored
fix: padding issue with the select tags (#3929)
* fix: padding issue with the select tags * chore: better solution from Lucas
1 parent 7de2131 commit e788c71

File tree

2 files changed

+10
-8
lines changed
  • frontend/appflowy_flutter
    • lib/plugins/database_view/widgets/row/cells/select_option_cell
    • packages/flowy_infra_ui/lib/style_widget

2 files changed

+10
-8
lines changed

frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/select_option_cell/extension.dart

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,8 @@ import 'package:appflowy_backend/protobuf/flowy-database2/select_option.pb.dart'
33

44
import 'package:flowy_infra/theme_extension.dart';
55
import 'package:flowy_infra/size.dart';
6+
import 'package:flowy_infra_ui/flowy_infra_ui.dart';
67
import 'package:flowy_infra_ui/style_widget/hover.dart';
7-
import 'package:flowy_infra_ui/style_widget/icon_button.dart';
8-
import 'package:flowy_infra_ui/style_widget/text.dart';
9-
import 'package:flowy_infra_ui/widget/spacing.dart';
108
import 'package:flutter/material.dart';
119
import 'package:easy_localization/easy_localization.dart';
1210
import 'package:appflowy/generated/locale_keys.g.dart';
@@ -93,7 +91,7 @@ class SelectOptionTag extends StatelessWidget {
9391
@override
9492
Widget build(BuildContext context) {
9593
EdgeInsets padding =
96-
const EdgeInsets.symmetric(vertical: 1.5, horizontal: 8.0);
94+
const EdgeInsets.symmetric(vertical: 2, horizontal: 8.0);
9795
if (onRemove != null) {
9896
padding = padding.copyWith(right: 2.0);
9997
}

frontend/appflowy_flutter/packages/flowy_infra_ui/lib/style_widget/text.dart

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
import 'dart:io';
2+
13
import 'package:flutter/material.dart';
24

35
class FlowyText extends StatelessWidget {
@@ -89,10 +91,12 @@ class FlowyText extends StatelessWidget {
8991
maxLines: maxLines,
9092
textAlign: textAlign,
9193
overflow: overflow ?? TextOverflow.clip,
92-
textHeightBehavior: const TextHeightBehavior(
93-
applyHeightToFirstAscent: false,
94-
applyHeightToLastDescent: false,
95-
),
94+
textHeightBehavior: Platform.isAndroid || Platform.isIOS
95+
? const TextHeightBehavior(
96+
applyHeightToFirstAscent: false,
97+
applyHeightToLastDescent: false,
98+
)
99+
: null,
96100
style: Theme.of(context).textTheme.bodyMedium!.copyWith(
97101
fontSize: fontSize,
98102
fontWeight: fontWeight,

0 commit comments

Comments
 (0)