Skip to content

Conversation

@appflowy
Copy link
Contributor

@appflowy appflowy commented May 11, 2025

Feature Preview


PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

Summary by Sourcery

Introduce automatic fetching of workspace subscription information during workspace initialization and opening, with corresponding event and state updates in the user workspace BLoC.

New Features:

  • Fetch and store workspace subscription information when initializing or opening a workspace.

Enhancements:

  • Add new event and state property for handling workspace subscription info in the user workspace BLoC.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented May 11, 2025

Reviewer's Guide

This pull request adds logic to fetch and store workspace subscription information when a workspace is initialized or opened, by introducing a new event and handler in the UserWorkspaceBloc. The implementation ensures that subscription info is retrieved and updated in the state as part of the workspace lifecycle.

File-Level Changes

Change Details Files
Added fetching and storing of workspace subscription info during workspace initialization and opening.
  • Introduced fetchWorkspaceSubscriptionInfo event and handler in UserWorkspaceBloc.
  • Called fetchWorkspaceSubscriptionInfo after initializing or opening a workspace.
  • Added workspaceSubscriptionInfo field to UserWorkspaceState to store subscription data.
frontend/appflowy_flutter/lib/workspace/application/user/user_workspace_bloc.dart

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@khorshuheng
Copy link
Contributor

What would happen if we are unable to fetch the subscription, say, for self hosters?

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @appflowy - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 2 issues found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Emitter<UserWorkspaceState> emit,
String workspaceId,
) async {
unawaited(UserBackendService.getWorkspaceSubscriptionInfo(workspaceId).fold(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (bug_risk): Detached call with unawaited means the function returns before fetch completes

Remove unawaited and await the fold result directly so this function’s Future represents the network call. Alternatively, adjust the caller to not assume _handleFetchWorkspaceSubscriptionInfo covers the fetch lifecycle.

@appflowy
Copy link
Contributor Author

What would happen if we are unable to fetch the subscription, say, for self hosters?

I've added billing check

@appflowy appflowy merged commit dfc80e6 into main May 11, 2025
3 checks passed
@appflowy appflowy deleted the subscription_info branch May 11, 2025 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants