Skip to content

Commit 764a5d7

Browse files
committed
Update timeouts and comments
1 parent cc788a9 commit 764a5d7

11 files changed

+28
-28
lines changed

.github/workflows/build-docker-monorepo.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ jobs:
2323
runs-on: ubuntu-latest
2424
permissions:
2525
contents: read
26-
timeout-minutes: 5 # 2025-03-04: Takes just a few seconds.
26+
timeout-minutes: 5 # 2025-11-20: Takes just a few seconds.
2727
outputs:
2828
php-version: ${{ steps.buildargs.outputs.php-version }}
2929
composer-version: ${{ steps.buildargs.outputs.composer-version }}
@@ -72,7 +72,7 @@ jobs:
7272
permissions:
7373
packages: write
7474
contents: read
75-
timeout-minutes: 15 # 2025-03-04: Arm64 build takes about 5 minutes, amd64 build about 3.
75+
timeout-minutes: 20 # 2025-11-20: Arm64 build takes about 6 minutes, amd64 build about 3.
7676
strategy:
7777
matrix:
7878
include:
@@ -148,7 +148,7 @@ jobs:
148148
permissions:
149149
packages: write
150150
contents: read
151-
timeout-minutes: 5 # 2025-03-04: Merge takes less than a minute.
151+
timeout-minutes: 5 # 2025-11-20: Merge takes less than a minute.
152152

153153
steps:
154154
- name: Download digests

.github/workflows/build-docker.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ jobs:
2525
runs-on: ubuntu-latest
2626
permissions:
2727
contents: read
28-
timeout-minutes: 5 # 2025-03-04: Takes just a few seconds.
28+
timeout-minutes: 5 # 2025-11-20: Takes just a few seconds.
2929
outputs:
3030
php-version: ${{ steps.buildargs.outputs.php-version }}
3131
composer-version: ${{ steps.buildargs.outputs.composer-version }}
@@ -74,7 +74,7 @@ jobs:
7474
permissions:
7575
packages: write
7676
contents: read
77-
timeout-minutes: 15 # 2025-03-04: Arm64 build takes about 5 minutes, amd64 build about 3.
77+
timeout-minutes: 20 # 2025-11-20: Arm64 build takes about 6 minutes, amd64 build about 3.
7878
strategy:
7979
matrix:
8080
include:
@@ -149,7 +149,7 @@ jobs:
149149
permissions:
150150
packages: write
151151
contents: read
152-
timeout-minutes: 5 # 2025-03-04: Merge takes less than a minute.
152+
timeout-minutes: 5 # 2025-11-20: Merge takes less than a minute.
153153

154154
steps:
155155
- name: Download digests

.github/workflows/coverage-check.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ jobs:
2525
if: >
2626
( github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.event.pull_request.base.repo.full_name ) &&
2727
( github.event_name == 'workflow_dispatch' || github.event.label.name == 'I don''t care about code coverage for this PR' || github.event.label.name == 'Covered by non-unit tests' || github.event.label.name == 'Coverage tests to be added later' )
28-
timeout-minutes: 5 # 2025-02-06: Should be pretty quick.
28+
timeout-minutes: 5 # 2025-11-20: Less than 30 seconds.
2929
steps:
3030
- name: Checkout
3131
uses: actions/checkout@v5

.github/workflows/delete-mirror-branches.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ jobs:
66
delete:
77
name: Delete `${{ github.event.ref }}`
88
runs-on: ubuntu-latest
9-
timeout-minutes: 5 # 2022-11-21: Shouldn't take long.
9+
timeout-minutes: 5 # 2025-11-20: Less than a minute.
1010
if: github.event_name == 'delete' && github.repository == 'Automattic/jetpack' && github.event.ref == 'prerelease'
1111
steps:
1212
- uses: actions/checkout@v5

.github/workflows/e2e-tests.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ jobs:
2020
create-test-matrix:
2121
name: "Determine tests matrix"
2222
runs-on: ubuntu-latest
23-
timeout-minutes: 5 # 2023-09-15: The pnpm install may take a few minutes on cache miss.
23+
timeout-minutes: 5 # 2025-11-20: The pnpm install may take a few minutes on cache miss.
2424
# Only run tests in the main repository
2525
if: github.event.pull_request.head.repo.full_name == github.event.pull_request.base.repo.full_name
2626
outputs:
@@ -70,7 +70,7 @@ jobs:
7070
name: "E2E: Build ${{ matrix.buildGroup }}"
7171
runs-on: ubuntu-latest
7272
needs: create-test-matrix
73-
timeout-minutes: 30
73+
timeout-minutes: 30 # 2025-11-20: These can vary dramatically, but most builds are around 5 minutes.
7474
if: needs.create-test-matrix.outputs.build-matrix != '[]'
7575
strategy:
7676
fail-fast: false
@@ -145,7 +145,7 @@ jobs:
145145
if: >
146146
always() && ! cancelled() && ! failure() &&
147147
needs.create-test-matrix.result == 'success' && needs.create-test-matrix.outputs.matrix != '[]'
148-
timeout-minutes: 60
148+
timeout-minutes: 60 # 2025-11-20: These can vary dramatically, but most runs are 3-10 minutes.
149149
env:
150150
WP_DEBUG_PATH: '${{ github.workspace }}/tools/docker/wordpress/wp-content/debug.log'
151151
PROJECT_NAME: '${{ matrix.project }}' # used in tests for enhanced reporting of global projects

.github/workflows/linting.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -631,7 +631,7 @@ jobs:
631631
runs-on: ubuntu-latest
632632
needs: changed_files
633633
if: github.event_name == 'pull_request' && needs.changed_files.outputs.phanstubs == 'true' && github.event.pull_request.user.login != 'matticbot'
634-
timeout-minutes: 5 # 2025-11-06: Probably takes about a minute, but shouldn't run often.
634+
timeout-minutes: 5 # 2025-11-06: Probably takes about a minute.
635635
steps:
636636
- uses: GitHubSecurityLab/actions-permissions/monitor@v1
637637
with:

.github/workflows/post-build.yml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ jobs:
3636
setup:
3737
name: Setup
3838
runs-on: ubuntu-latest
39-
timeout-minutes: 2 # 2022-12-20: Seems like it should be fast.
39+
timeout-minutes: 2 # 2025-11-20: Takes a few seconds.
4040
outputs:
4141
upgrade_check: ${{ steps.upgrade_check.outputs.id }}
4242
wpcom_filename_check: ${{ steps.wpcom_filename_check.outputs.id }}
@@ -83,7 +83,7 @@ jobs:
8383
runs-on: ubuntu-latest
8484
needs: setup
8585
if: github.event.workflow_run.conclusion != 'success'
86-
timeout-minutes: 2 # 2022-08-26: Seems like it should be fast.
86+
timeout-minutes: 2 # 2025-11-20: Seems like it should be fast.
8787
steps:
8888
- uses: actions/checkout@v5
8989

@@ -123,7 +123,7 @@ jobs:
123123
runs-on: ubuntu-latest
124124
needs: setup
125125
if: github.event.workflow_run.conclusion == 'success'
126-
timeout-minutes: 2 # 2022-08-26: Seems like it should be fast.
126+
timeout-minutes: 2 # 2025-11-20: Takes a few seconds.
127127
outputs:
128128
zip_url: ${{ steps.run.outputs.zip_url }}
129129
any_plugins: ${{ steps.run.outputs.any_plugins }}
@@ -199,7 +199,7 @@ jobs:
199199
runs-on: ubuntu-latest
200200
needs: [ setup, find_artifact ]
201201
if: needs.find_artifact.outputs.any_plugins == 'false'
202-
timeout-minutes: 2 # 2022-08-26: Seems like it should be fast.
202+
timeout-minutes: 2 # 2025-11-20: Takes a few seconds.
203203
steps:
204204
- uses: actions/checkout@v5
205205

@@ -241,7 +241,7 @@ jobs:
241241
if: needs.find_artifact.outputs.any_plugins == 'true'
242242
outputs:
243243
matrix: ${{ steps.matrix.outputs.matrix }}
244-
timeout-minutes: 5 # 2025-03-13: Should be just a few seconds.
244+
timeout-minutes: 5 # 2025-11-20: Takes a few seconds.
245245

246246
steps:
247247
- uses: actions/checkout@v5
@@ -302,7 +302,7 @@ jobs:
302302
runs-on: ubuntu-latest
303303
needs: [ setup, find_artifact, prepare_upgrade_test ]
304304
if: needs.find_artifact.outputs.any_plugins == 'true'
305-
timeout-minutes: 15 # 2025-11-06: Successful runs seem to take about 3 minutes, but give some extra time for the downloads.
305+
timeout-minutes: 15 # 2025-11-20: Successful runs seem to take about 2 minutes, but give some extra time for the downloads.
306306
strategy:
307307
fail-fast: false
308308
matrix:
@@ -380,7 +380,7 @@ jobs:
380380
runs-on: ubuntu-latest
381381
needs: [ setup, find_artifact, upgrade_test ]
382382
if: always() && needs.find_artifact.outputs.any_plugins == 'true'
383-
timeout-minutes: 5 # 2025-03-13: Should be just a few seconds.
383+
timeout-minutes: 5 # 2025-11-20: Takes a few seconds.
384384

385385
steps:
386386
- uses: actions/checkout@v5
@@ -412,7 +412,7 @@ jobs:
412412
runs-on: ubuntu-latest
413413
needs: [ setup, find_artifact ]
414414
if: needs.find_artifact.outputs.any_plugins == 'true'
415-
timeout-minutes: 15 # 2025-03-03: Guess. Leave time for the downloads.
415+
timeout-minutes: 15 # 2025-11-20: Less than a minute, but leave time for the downloads.
416416
steps:
417417
- uses: actions/checkout@v5
418418
with:

.github/workflows/pr-is-up-to-date.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ jobs:
1212
check:
1313
name: Check
1414
runs-on: ubuntu-latest
15-
timeout-minutes: 5 # 2021-03-23: The run on push to the tag might take a minute or two.
15+
timeout-minutes: 5 # 2025-11-20: The run on push to the tag might take a minute or two.
1616
steps:
1717

1818
# We basically have two workflows in one here, one for pushes to trunk and one for PRs and pushes to tags.

.github/workflows/slack-branch-existence-notification.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ jobs:
77
notify:
88
name: Notify
99
runs-on: ubuntu-latest
10-
timeout-minutes: 5 # 2022-11-22: Shouldn't take long.
10+
timeout-minutes: 5 # 2025-11-20: Takes a few seconds.
1111
if: github.event.ref == 'prerelease'
1212

1313
steps:

.github/workflows/stale.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ on:
88
jobs:
99
stale:
1010
runs-on: ubuntu-latest
11-
timeout-minutes: 10
11+
timeout-minutes: 10 # 2025-11-20: Takes less than a minute.
1212
steps:
1313
- uses: actions/stale@v10
1414
with:
@@ -44,4 +44,4 @@ jobs:
4444
If you want to resume work on the PR, feel free to restore the branch and reopen the PR.</p>
4545
# Ignore issues, only operating on pull requests.
4646
days-before-issue-stale: -1
47-
days-before-issue-close: -1
47+
days-before-issue-close: -1

0 commit comments

Comments
 (0)