e2e tests: Improve Social E2E connection test helper #45135
Description
The current connection test helper in Social E2E tests uses spinner waiting with an unusual timeout that could lead to flaky tests.
Current Issue:
- Uses spinner-based waiting approach that may be unreliable
- Has unusual timeout handling that could cause test instability
Proposed Solution:
Replace the current implementation with the more robust approach used in Jetpack's onboarding helper:
- Create site connection promise
- Start connection process
- Wait for connection completion
- Wait for redirect
- Approve connection
Context:
Discussion from this comment in PR #44588 suggested using the pattern from Jetpack plugin's onboarding helper for more reliable connection testing.