Skip to content

CI: Update timeouts and comments (part 2) #46037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 21, 2025
Merged

CI: Update timeouts and comments (part 2) #46037

merged 3 commits into from
Nov 21, 2025
+28 −28

Conversation

@tbradsha
Copy link
Contributor

@tbradsha tbradsha commented Nov 20, 2025 •
edited by robertsreberski
Loading

Closes MONOREP-246

In #45803 I did some (I'm not sure why I didn't do them all). This PR wraps it up so that all timeouts and comments are based on observations in November 2025.

Well, with one exception. I bumped the Phan run timeout and comment in #46036.

Proposed changes:

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

As long as nothing times out (any changes should have bumped upward), this should be safe.

@tbradsha tbradsha requested a review from a team November 20, 2025 22:51
@tbradsha tbradsha self-assigned this Nov 20, 2025
@tbradsha tbradsha added [Status] Needs Review This PR is ready for review. [Type] Janitorial labels Nov 20, 2025
@github-actions github-actions bot added the Actions GitHub actions used to automate some of the work around releases and repository management label Nov 20, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 20, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@jp-launch-control
Copy link

jp-launch-control bot commented Nov 20, 2025 •
edited
Loading

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

anomiex
anomiex previously approved these changes Nov 21, 2025
View reviewed changes
Copy link
Contributor

@anomiex anomiex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine. A few comments inline, but nothing I'd block a merge over.

.github/workflows/build-docker-monorepo.yml Outdated
packages: write
contents: read
timeout-minutes: 15 # 2025-03-04: Arm64 build takes about 5 minutes, amd64 build about 3.
timeout-minutes: 20 # 2025-11-20: Arm64 build takes about 6 minutes, amd64 build about 3.
Copy link
Contributor

@anomiex anomiex Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷 15 seems ok to me to cover a 6-minute run.

Copy link
Contributor Author

@tbradsha tbradsha Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, I may have been adding the times when looking at it initially. Bumped back down: bd11ec3

.github/workflows/build-docker.yml Outdated
packages: write
contents: read
timeout-minutes: 15 # 2025-03-04: Arm64 build takes about 5 minutes, amd64 build about 3.
timeout-minutes: 20 # 2025-11-20: Arm64 build takes about 6 minutes, amd64 build about 3.
Copy link
Contributor

@anomiex anomiex Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

Copy link
Contributor Author

@tbradsha tbradsha Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bd11ec3

.github/workflows/e2e-tests.yml Outdated
always() && ! cancelled() && ! failure() &&
needs.create-test-matrix.result == 'success' && needs.create-test-matrix.outputs.matrix != '[]'
timeout-minutes: 60
timeout-minutes: 60 # 2025-11-20: These can vary dramatically, but most runs are 3-10 minutes.
Copy link
Contributor

@anomiex anomiex Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if 60 is too much here. How dramatically do they vary?

Copy link
Contributor Author

@tbradsha tbradsha Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's complicated; if there are slow network issues or something, some of the tests take a while, and then fail, and then rerun. But 60 is probably excessive. I'll bump 'em down to 25 minutes: 2e01539

@tbradsha tbradsha merged commit 8064aa9 into trunk Nov 21, 2025
72 checks passed
@tbradsha tbradsha deleted the update/tooling/workflow_timeout_audit branch November 21, 2025 17:59
@github-actions github-actions bot removed the [Status] Needs Review This PR is ready for review. label Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anomiex anomiex anomiex approved these changes

Assignees

@tbradsha tbradsha

Labels

Actions GitHub actions used to automate some of the work around releases and repository management [Type] Janitorial

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tbradsha @anomiex