Skip to content

AVM: Reinstate NoopUpdateCheck for simulate_fast with hint collection #18161

@MirandaWood

Description

@MirandaWood

Currently only exists in #18130
When we simulate with hint collecting dbs, we unfortunately needed to use a 'real' UpdateCheck which increases overhead:

    // NoopUpdateCheck update_check;
    // TODO(MW): Note that if we need to gather hints here, we can't use the NoopUpdateCheck as it will skip collecting
    // a required hint for a storage_read. Optionally use Noop if we don't need hints:

    UpdateCheck update_check(poseidon2, range_check, greater_than, merkle_db, update_check_emitter, global_variables);

This is because the NoopUpdateCheck will not perform the required storage reads we need to collect merkle db hints for future witness generation. At this stage, we don't require the heavy poseidon operations so would ideally remove those but still collect the required read hints.

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions