Skip to content

Commit ef14700

Browse files
Merge pull request #260 from sharifrahaman/uifabric-icon-cdn
Upgrade fluentui react to 8.122.9 and fix VideoOff2 icon
2 parents 67ab825 + fa696cb commit ef14700

20 files changed

+252
-395
lines changed

Project/package-lock.json

Lines changed: 205 additions & 343 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Project/package.json

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,15 +3,16 @@
33
"version": "1.0.0",
44
"private": true,
55
"dependencies": {
6-
"@azure/communication-calling": "1.27.1-beta.1",
6+
"@azure/communication-calling": "1.33.2-beta.1",
77
"@azure/communication-calling-effects": "1.1.1-beta.1",
88
"@azure/communication-common": "^2.3.0",
99
"@azure/communication-identity": "^1.3.0",
1010
"@azure/communication-network-traversal": "^1.1.0-beta.1",
1111
"@azure/logger": "^1.0.3",
1212
"@azure/msal-browser": "^2.33.0",
1313
"@azure/msal-node": "^1.17.1",
14-
"@fluentui/react": "^7.158.1",
14+
"@fluentui/react": "^8.122.9",
15+
"@fluentui/react-icons-mdl2": "^1.3.82",
1516
"@microsoft/applicationinsights-web": "^3.0.2",
1617
"pako": "^2.1.0",
1718
"react": "^16.14.0",

Project/src/App.js

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,18 @@
11
import React, { useState } from 'react';
22
import './App.css';
33
import MakeCall from './MakeCall/MakeCall'
4-
import { initializeIcons } from '@uifabric/icons';
4+
import { initializeIcons } from '@fluentui/font-icons-mdl2';
5+
import { registerIcons } from '@fluentui/react/lib/Styling';
6+
import { VideoOff2Icon } from '@fluentui/react-icons-mdl2';
57
import { ToastContainer } from 'react-toastify';
68

7-
initializeIcons('https://res.cdn.office.net/files/fabric-cdn-prod_20241209.001/assets/icons/');
9+
initializeIcons();
10+
// VideoOff2 is not available in fluentui/react-icons-mdl2. So we need to use fluentui/font-icons-mdl2 to register the icon and use it.
11+
registerIcons({
12+
icons: {
13+
VideoOff2: <VideoOff2Icon style={{verticalAlign: 'baseline'}} />
14+
}
15+
});
816

917
function App() {
1018
let [users, setUsers] = useState([<MakeCall/>]);

Project/src/MakeCall/AddParticipantPopover.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import React, { useState } from "react";
2-
import { PrimaryButton, TextField } from 'office-ui-fabric-react';
2+
import { PrimaryButton } from '@fluentui/react/lib/Button';
3+
import { TextField } from '@fluentui/react/lib/TextField';
34
import { CallKind } from "@azure/communication-calling";
45
import { createIdentifierFromRawId } from '@azure/communication-common';
56

Project/src/MakeCall/CallCaption.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import React, { useEffect, useState } from "react";
22
import { Features } from '@azure/communication-calling';
3-
import { Dropdown } from 'office-ui-fabric-react/lib/Dropdown';
3+
import { Dropdown } from '@fluentui/react/lib/Dropdown';
44

55
// CallCaption react function component
66
const CallCaption = ({ call }) => {

Project/src/MakeCall/CallCard.js

Lines changed: 4 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
import React from "react";
2-
import { MessageBar, MessageBarType } from 'office-ui-fabric-react'
2+
import { MessageBar, MessageBarType } from '@fluentui/react'
33
import { FunctionalStreamRenderer as StreamRenderer } from "./FunctionalStreamRenderer";
44
import AddParticipantPopover from "./AddParticipantPopover";
55
import RemoteParticipantCard from "./RemoteParticipantCard";
6-
import { Panel, PanelType } from 'office-ui-fabric-react/lib/Panel';
6+
import { Panel, PanelType } from '@fluentui/react/lib/Panel';
77
import { Icon } from '@fluentui/react/lib/Icon';
88
import LocalVideoPreviewCard from './LocalVideoPreviewCard';
9-
import { Dropdown } from 'office-ui-fabric-react/lib/Dropdown';
9+
import { Dropdown } from '@fluentui/react/lib/Dropdown';
1010
import { LocalVideoStream, Features, LocalAudioStream } from '@azure/communication-calling';
1111
import { utils } from '../Utils/Utils';
1212
import CustomVideoEffects from "./RawVideoAccess/CustomVideoEffects";
@@ -1545,18 +1545,7 @@ export default class CallCard extends React.Component {
15451545
title = {`${this.state.canOnVideo ? (this.state.videoOn ? 'Turn your video off' : 'Turn your video on') : 'Video is disabled'}`}
15461546
variant="secondary"
15471547
onClick={() => this.handleVideoOnOff()}>
1548-
{
1549-
this.state.canOnVideo && this.state.videoOn &&
1550-
<Icon iconName="Video" />
1551-
}
1552-
{
1553-
(this.state.canOnVideo && !this.state.videoOn) &&
1554-
<Icon iconName="VideoOff2" />
1555-
}
1556-
{
1557-
(!this.state.canOnVideo) &&
1558-
<Icon iconName="VideoOff" />
1559-
}
1548+
<Icon iconName={`${this.state.canOnVideo ? (this.state.videoOn ? 'Video' : 'VideoOff2') : 'VideoOff'}`} />
15601549
</span>
15611550
<span className="in-call-button"
15621551
title={`${this.state.canUnMuteMic ? (this.state.micMuted ? 'Unmute your microphone' : 'Mute your microphone') : 'Microphone is disabled'}`}

Project/src/MakeCall/CallSurvey.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
import React from "react";
22
import {
33
PrimaryButton
4-
} from 'office-ui-fabric-react'
4+
} from '@fluentui/react/lib/Button'
55
import StarRating from '../MakeCall/StarRating';
66
import { Features } from '@azure/communication-calling';
77
import config from '../../clientConfig.json';
88
import { ApplicationInsights } from '@microsoft/applicationinsights-web';
9-
import { TextField } from 'office-ui-fabric-react';
9+
import { TextField } from '@fluentui/react/lib/TextField';
1010

1111
export default class CallSurvey extends React.Component {
1212
constructor(props) {

Project/src/MakeCall/DataChannelCard.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,9 @@ import React from "react";
22
import { ToastContainer, toast } from 'react-toastify';
33
import { Features } from '@azure/communication-calling';
44
import 'react-toastify/dist/ReactToastify.css';
5-
import { PrimaryButton, TextField } from 'office-ui-fabric-react';
5+
import { PrimaryButton } from '@fluentui/react/lib/Button';
6+
import { TextField } from '@fluentui/react/lib/TextField';
7+
68
import { utils } from '../Utils/Utils';
79

810
const toastOptions = {

Project/src/MakeCall/Lobby.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import React from "react";
2-
import { PrimaryButton } from 'office-ui-fabric-react';
2+
import { PrimaryButton } from '@fluentui/react/lib/Button';
33
import { Features } from '@azure/communication-calling';
44

55
// Lobby react function component

Project/src/MakeCall/Login.js

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
11
import React from "react";
2-
import {
3-
TextField, PrimaryButton, Checkbox,
4-
MessageBar, MessageBarType
5-
} from 'office-ui-fabric-react'
2+
import { Checkbox, MessageBar, MessageBarType } from '@fluentui/react';
3+
import { PrimaryButton } from '@fluentui/react/lib/Button';
4+
import { TextField } from '@fluentui/react/lib/TextField';
65
import { Features } from "@azure/communication-calling";
76
import { utils } from "../Utils/Utils";
87
import { v4 as uuid } from 'uuid';

0 commit comments

Comments
 (0)