Fix minified build so workers directory doesn't have content (#4609)

Author: aishwaryabh

eng/build/Minified.targets

@@ -2,17 +2,24 @@
 
   <!-- Workers to delete in minified builds -->
   <ItemGroup Condition="'$(IsMinified)' == 'true'">
-    <_LanguageWorkers Include="$(PublishDir)workers\python" />
-    <_LanguageWorkers Include="$(PublishDir)workers\java" />
-    <_LanguageWorkers Include="$(PublishDir)workers\powershell" />
-    <_LanguageWorkers Include="$(PublishDir)workers\node" />
+    <_LanguageWorkers Include="$(PublishDir)\workers\python" />
+    <_LanguageWorkers Include="$(PublishDir)\workers\java" />
+    <_LanguageWorkers Include="$(PublishDir)\workers\powershell" />
+    <_LanguageWorkers Include="$(PublishDir)\workers\node" />
   </ItemGroup>
 
   <!-- Remove worker directories from minified builds -->
   <!-- Cannot remove entire directory due to this bug: https://github.com/Azure/azure-functions-core-tools/issues/2380 -->
   <Target Name="RemoveLanguageWorkersForMin" AfterTargets="Publish" BeforeTargets="PrepareZipArtifacts" Condition="'$(RuntimeIdentifier)' != ''">
     <Message Importance="low" Text="Removing language workers for minified build..."  />
     <RemoveDir Directories="@(_LanguageWorkers)" />
+    
+  <!-- Check if any directories still exist and fail the build -->
+    <ItemGroup>
+      <_FailedToDelete Include="@(_LanguageWorkers)" Condition="Exists('%(Identity)')" />
+    </ItemGroup>
+
+    <Error Text="Failed to delete one or more language worker directories: %(Identity)" Condition="'@(_FailedToDelete)' != ''" />
   </Target>
 
   <!-- Write artifactsconfig.json for minified builds -->

eng/ci/templates/official/jobs/test-consolidated-cli-artifacts.yml

@@ -40,6 +40,22 @@ jobs:
     displayName: 'Download artifact'
     artifact: func-cli-${{ parameters.arch }}
 
+  - ${{ if startsWith(parameters.arch, 'min.') }}:
+    - task: ExtractFiles@1
+      displayName: 'Unzip func-cli (minified)'
+      inputs:
+        archiveFilePatterns: '$(Pipeline.Workspace)/func-cli-${{ parameters.arch }}/func-cli/*.zip'
+        destinationFolder: '$(Pipeline.Workspace)/minified-test'
+        cleanDestinationFolder: true
+        overwriteExistingFiles: true
+
+    - task: PowerShell@2
+      displayName: 'Verify workers directory is empty for minified build'
+      inputs:
+        targetType: filePath
+        filePath: '$(Build.SourcesDirectory)/eng/scripts/artifact-assembler/check-minified-dir-exists.ps1'
+        arguments: '-workersPath "$(Pipeline.Workspace)/minified-test/workers"'
+
   # Testing for non-min versions of the CLI as some of the tests require the workers.
   - ${{ if not(startsWith(parameters.arch, 'min.')) }}:
     - task: ExtractFiles@1

eng/scripts/artifact-assembler/check-minified-dir-exists.ps1

@@ -0,0 +1,16 @@
+param (
+    [string]$workersPath
+)
+
+if (-Not (Test-Path $workersPath)) {
+    Write-Error "Workers directory is missing at $workersPath. It must exist in minified builds."
+}
+
+$contents = Get-ChildItem -Path $workersPath
+
+# Filter out placeholder.txt
+$nonPlaceholderContents = $contents | Where-Object { $_.Name -ne "placeholder.txt" }
+
+if ($nonPlaceholderContents.Count -ne 0) {
+    Write-Error "Workers directory contains unexpected files. Only 'placeholder.txt' is allowed in minified builds."
+}

release_notes.md

@@ -1,4 +1,4 @@
-# Azure Functions CLI 4.2.0
+# Azure Functions CLI 4.2.1
 
 #### Host Version
 
@@ -9,3 +9,4 @@
 
 - Add support for .NET 10 isolated model (#4589)
 - Update log streaming to support both connection string and instrumentation Key (#4586)
+- Remove content of workers dir from minified versions (#4609)

src/Cli/func/Directory.Version.props

@@ -1,7 +1,7 @@
 <Project>
 
   <PropertyGroup>
-    <VersionPrefix>4.2.0</VersionPrefix>
+    <VersionPrefix>4.2.1</VersionPrefix>
     <VersionSuffix></VersionSuffix>
     <UpdateBuildNumber>true</UpdateBuildNumber>
   </PropertyGroup>