Added Unit Testcases for Group List Command (#694)

* Added Testcases for Group List Command

* Addressed review comments

Author: anannya03

tests/Areas/Group/UnitTests/GroupListCommandTests.cs

@@ -0,0 +1,183 @@
+// Copyright (c) Microsoft Corporation.
+// Licensed under the MIT License.
+
+using System.CommandLine;
+using System.CommandLine.Parsing;
+using System.Text.Json;
+using AzureMcp.Areas.Group.Commands;
+using AzureMcp.Models.Command;
+using AzureMcp.Models.ResourceGroup;
+using AzureMcp.Options;
+using AzureMcp.Services.Azure.ResourceGroup;
+using AzureMcp.Tests.Helpers;
+using Microsoft.Extensions.DependencyInjection;
+using Microsoft.Extensions.Logging;
+using ModelContextProtocol.Server;
+using NSubstitute;
+using Xunit;
+
+namespace AzureMcp.Tests.Areas.Group.UnitTests;
+
+[Trait("Area", "Group")]
+public class GroupListCommandTests
+{
+    private readonly IServiceProvider _serviceProvider;
+    private readonly IMcpServer _mcpServer;
+    private readonly ILogger<GroupListCommand> _logger;
+    private readonly IResourceGroupService _resourceGroupService;
+    private readonly GroupListCommand _command;
+    private readonly CommandContext _context;
+    private readonly Parser _parser;
+
+    public GroupListCommandTests()
+    {
+        _mcpServer = Substitute.For<IMcpServer>();
+        _resourceGroupService = Substitute.For<IResourceGroupService>();
+        _logger = Substitute.For<ILogger<GroupListCommand>>();
+        var collection = new ServiceCollection()
+            .AddSingleton(_mcpServer)
+            .AddSingleton(_resourceGroupService);
+
+        _serviceProvider = collection.BuildServiceProvider();
+        _command = new(_logger);
+        _context = new(_serviceProvider);
+        _parser = new(_command.GetCommand());
+    }
+
+    [Fact]
+    public async Task ExecuteAsync_WithValidSubscription_ReturnsResourceGroups()
+    {
+        // Arrange
+        var subscriptionId = "test-subscription-id";
+        var expectedGroups = new List<ResourceGroupInfo>
+        {
+            ResourceGroupTestHelpers.CreateResourceGroupInfo("rg1", subscriptionId, "East US"),
+            ResourceGroupTestHelpers.CreateResourceGroupInfo("rg2", subscriptionId, "West US")
+        };
+
+        _resourceGroupService
+            .GetResourceGroups(Arg.Is<string>(x => x == subscriptionId), Arg.Any<string>(), Arg.Any<RetryPolicyOptions>())
+            .Returns(expectedGroups);
+
+        var args = _parser.Parse($"--subscription {subscriptionId}");
+
+        // Act
+        var result = await _command.ExecuteAsync(_context, args);
+
+        // Assert
+        Assert.NotNull(result);
+        Assert.Equal(200, result.Status);
+        Assert.NotNull(result.Results);
+
+        var jsonDoc = JsonDocument.Parse(JsonSerializer.Serialize(result.Results));
+        var groupsArray = jsonDoc.RootElement.GetProperty("groups");
+
+        Assert.Equal(2, groupsArray.GetArrayLength());
+
+        var first = groupsArray[0];
+        var second = groupsArray[1];
+
+        Assert.Equal("rg1", first.GetProperty("name").GetString());
+        Assert.Equal("/subscriptions/test-subscription-id/resourceGroups/rg1", first.GetProperty("id").GetString());
+        Assert.Equal("East US", first.GetProperty("location").GetString());
+
+        Assert.Equal("rg2", second.GetProperty("name").GetString());
+        Assert.Equal("/subscriptions/test-subscription-id/resourceGroups/rg2", second.GetProperty("id").GetString());
+        Assert.Equal("West US", second.GetProperty("location").GetString());
+
+        await _resourceGroupService.Received(1).GetResourceGroups(
+            Arg.Is<string>(x => x == subscriptionId),
+            Arg.Any<string>(),
+            Arg.Any<RetryPolicyOptions>());
+    }
+
+    [Fact]
+    public async Task ExecuteAsync_WithTenant_PassesTenantToService()
+    {
+        // Arrange
+        var subscriptionId = "test-subscription-id";
+        var tenantId = "test-tenant-id";
+        var expectedGroups = new List<ResourceGroupInfo>
+        {
+            ResourceGroupTestHelpers.CreateResourceGroupInfo("rg1", subscriptionId, "East US")
+        };
+
+        _resourceGroupService
+            .GetResourceGroups(
+                Arg.Is<string>(x => x == subscriptionId),
+                Arg.Is<string>(x => x == tenantId),
+                Arg.Any<RetryPolicyOptions>())
+            .Returns(expectedGroups);
+
+        var args = _parser.Parse($"--subscription {subscriptionId} --tenant {tenantId}");
+
+        // Act
+        var result = await _command.ExecuteAsync(_context, args);
+
+        // Assert
+        Assert.NotNull(result);
+        Assert.Equal(200, result.Status);
+        await _resourceGroupService.Received(1).GetResourceGroups(
+            Arg.Is<string>(x => x == subscriptionId),
+            Arg.Is<string>(x => x == tenantId),
+            Arg.Any<RetryPolicyOptions>());
+    }
+
+    [Fact]
+    public async Task ExecuteAsync_EmptyResourceGroupList_ReturnsNullResults()
+    {
+        // Arrange
+        var subscriptionId = "test-subscription-id";
+        _resourceGroupService
+            .GetResourceGroups(Arg.Any<string>(), Arg.Any<string>(), Arg.Any<RetryPolicyOptions>())
+            .Returns([]);
+
+        var args = _parser.Parse($"--subscription {subscriptionId}");
+
+        // Act
+        var result = await _command.ExecuteAsync(_context, args);
+
+        // Assert
+        Assert.NotNull(result);
+        Assert.Equal(200, result.Status);
+        Assert.Null(result.Results);
+    }
+
+    [Fact]
+    public async Task ExecuteAsync_ServiceThrowsException_ReturnsErrorInResponse()
+    {
+        // Arrange
+        var subscriptionId = "test-subscription-id";
+        var expectedError = "Test error message";
+        _resourceGroupService
+            .GetResourceGroups(Arg.Any<string>(), Arg.Any<string>(), Arg.Any<RetryPolicyOptions>())
+            .Returns(Task.FromException<List<ResourceGroupInfo>>(new Exception(expectedError)));
+
+        var args = _parser.Parse($"--subscription {subscriptionId}");
+
+        // Act
+        var result = await _command.ExecuteAsync(_context, args);
+
+        // Assert
+        Assert.NotNull(result);
+        Assert.Equal(500, result.Status);
+        Assert.Contains(expectedError, result.Message);
+    }
+
+    [Fact]
+    public async Task ExecuteAsync_MissingSubscription_FailsValidation()
+    {
+        // Arrange
+        var args = _parser.Parse(""); // No subscription provided
+
+        // Act
+        var result = await _command.ExecuteAsync(_context, args);
+
+        // Assert
+        Assert.NotNull(result);
+        Assert.Equal(400, result.Status);
+        Assert.Contains("required", result.Message.ToLower());
+        // Verify service was not called when validation fails
+        await _resourceGroupService.DidNotReceive().GetResourceGroups(Arg.Any<string>(), Arg.Any<string>(), Arg.Any<RetryPolicyOptions>());
+    }
+}

tests/Helpers/ResourceGroupTestHelpers.cs

@@ -0,0 +1,27 @@
+// Copyright (c) Microsoft Corporation.
+// Licensed under the MIT License.
+
+using AzureMcp.Models.ResourceGroup;
+
+namespace AzureMcp.Tests.Helpers;
+
+/// <summary>
+/// Helper methods for creating test resource group data.
+/// </summary>
+public static class ResourceGroupTestHelpers
+{
+    /// <summary>
+    /// Creates a ResourceGroupInfo with the specified properties for testing.
+    /// </summary>
+    /// <param name="name">The name of the resource group</param>
+    /// <param name="subscriptionId">The subscription ID (used to construct the full resource ID)</param>
+    /// <param name="location">The Azure region/location</param>
+    /// <returns>A ResourceGroupInfo instance for testing</returns>
+    public static ResourceGroupInfo CreateResourceGroupInfo(string name, string subscriptionId, string location)
+    {
+        var id = $"/subscriptions/{subscriptionId}/resourceGroups/{name}";
+        return new ResourceGroupInfo(name, id, location);
+    }
+
+
+}