Skip to content

Commit 2ac729e

Browse files
committed
remove useless suppress
1 parent 48d5ac9 commit 2ac729e

File tree

2 files changed

+18
-25
lines changed

2 files changed

+18
-25
lines changed

specification/trafficmanager/TrafficManager.Management/models.tsp

Lines changed: 14 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -271,32 +271,28 @@ model EndpointPropertiesCustomHeadersItem {
271271
/**
272272
* The resource model definition for a ARM proxy resource. It will have everything other than required location and tags
273273
*/
274-
#suppress "@azure-tools/typespec-azure-core/no-legacy-usage" "For backward compatibility"
275-
#suppress "@azure-tools/typespec-azure-resource-manager/arm-custom-resource-no-key" "For backward compatibility"
276-
#suppress "@azure-tools/typespec-azure-resource-manager/arm-custom-resource-usage-discourage" "For backward compatibility"
277-
#suppress "@azure-tools/typespec-azure-core/composition-over-inheritance" "For backward compatibility"
278-
#suppress "@azure-tools/typespec-azure-resource-manager/no-empty-model" "For backward compatibility"
274+
#suppress "@azure-tools/typespec-azure-core/no-legacy-usage" "FIXME: Update justification, follow aka.ms/tsp/conversion-fix for details"
275+
#suppress "@azure-tools/typespec-azure-resource-manager/arm-custom-resource-no-key" "FIXME: Update justification, follow aka.ms/tsp/conversion-fix for details"
276+
#suppress "@azure-tools/typespec-azure-resource-manager/arm-custom-resource-usage-discourage" "FIXME: Update justification, follow aka.ms/tsp/conversion-fix for details"
279277
@Azure.ResourceManager.Legacy.customAzureResource
280278
model ProxyResource {
281279
/**
282-
* Fully qualified resource ID for the resource. Ex - /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/{resourceProviderNamespace}/{resourceType}/{resourceName}
280+
* ARM resource id of the resource.
283281
*/
284282
id?: Azure.Core.armResourceIdentifier;
285283

286284
/**
287-
* The name of the resource
285+
* Name of the resource.
288286
*/
289-
#suppress "@azure-tools/typespec-azure-core/documentation-required" "For backward compatibility"
290-
@segment("{endpointType}")
291287
name?: string;
292288

293289
/**
294-
* The type of the resource. E.g. "Microsoft.Compute/virtualMachines" or "Microsoft.Storage/storageAccounts".
290+
* The type of the resource.
295291
*/
296292
type?: Azure.Core.armResourceType;
297293

298294
/**
299-
* Azure Resource Manager metadata containing createdBy and modifiedBy information.
295+
* Azure Resource Manager metadata containing createdBy and modifiedBy information.
300296
*/
301297
systemData?: Azure.ResourceManager.CommonTypes.SystemData;
302298
}
@@ -596,31 +592,28 @@ model MonitorConfigExpectedStatusCodeRangesItem {
596592
/**
597593
* The resource model definition for a ARM tracked top level resource
598594
*/
599-
#suppress "@azure-tools/typespec-azure-core/no-legacy-usage" "For backward compatibility"
600-
#suppress "@azure-tools/typespec-azure-resource-manager/arm-custom-resource-no-key" "For backward compatibility"
601-
#suppress "@azure-tools/typespec-azure-resource-manager/arm-custom-resource-usage-discourage" "For backward compatibility"
602-
#suppress "@azure-tools/typespec-azure-core/composition-over-inheritance" "For backward compatibility"
595+
#suppress "@azure-tools/typespec-azure-core/no-legacy-usage" "FIXME: Update justification, follow aka.ms/tsp/conversion-fix for details"
596+
#suppress "@azure-tools/typespec-azure-resource-manager/arm-custom-resource-no-key" "FIXME: Update justification, follow aka.ms/tsp/conversion-fix for details"
597+
#suppress "@azure-tools/typespec-azure-resource-manager/arm-custom-resource-usage-discourage" "FIXME: Update justification, follow aka.ms/tsp/conversion-fix for details"
603598
@Azure.ResourceManager.Legacy.customAzureResource
604599
model TrackedResource {
605600
/**
606-
* Fully qualified resource ID for the resource. Ex - /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/{resourceProviderNamespace}/{resourceType}/{resourceName}
601+
* ARM resource id of the resource.
607602
*/
608603
id?: Azure.Core.armResourceIdentifier;
609604

610605
/**
611-
* The name of the resource
606+
* Name of the resource.
612607
*/
613-
#suppress "@azure-tools/typespec-azure-core/documentation-required" "For backward compatibility"
614-
@segment("trafficmanagerprofiles")
615608
name?: string;
616609

617610
/**
618-
* The type of the resource. E.g. "Microsoft.Compute/virtualMachines" or "Microsoft.Storage/storageAccounts".
611+
* The type of the resource.
619612
*/
620613
type?: Azure.Core.armResourceType;
621614

622615
/**
623-
* Azure Resource Manager metadata containing createdBy and modifiedBy information.
616+
* Azure Resource Manager metadata containing createdBy and modifiedBy information.
624617
*/
625618
systemData?: Azure.ResourceManager.CommonTypes.SystemData;
626619

specification/trafficmanager/resource-manager/Microsoft.Network/stable/2022-04-01/trafficmanager.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1124,15 +1124,15 @@
11241124
"id": {
11251125
"type": "string",
11261126
"format": "arm-id",
1127-
"description": "Fully qualified resource ID for the resource. Ex - /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/{resourceProviderNamespace}/{resourceType}/{resourceName}"
1127+
"description": "ARM resource id of the resource."
11281128
},
11291129
"name": {
11301130
"type": "string",
11311131
"description": "The name of the Traffic Manager endpoint."
11321132
},
11331133
"type": {
11341134
"$ref": "#/definitions/Azure.Core.armResourceType",
1135-
"description": "The type of the resource. E.g. \"Microsoft.Compute/virtualMachines\" or \"Microsoft.Storage/storageAccounts\"."
1135+
"description": "The type of the resource."
11361136
},
11371137
"systemData": {
11381138
"$ref": "../../../../../common-types/resource-management/v3/types.json#/definitions/systemData",
@@ -1510,15 +1510,15 @@
15101510
"id": {
15111511
"type": "string",
15121512
"format": "arm-id",
1513-
"description": "Fully qualified resource ID for the resource. Ex - /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/{resourceProviderNamespace}/{resourceType}/{resourceName}"
1513+
"description": "ARM resource id of the resource."
15141514
},
15151515
"name": {
15161516
"type": "string",
15171517
"description": "The name of the Traffic Manager profile."
15181518
},
15191519
"type": {
15201520
"$ref": "#/definitions/Azure.Core.armResourceType",
1521-
"description": "The type of the resource. E.g. \"Microsoft.Compute/virtualMachines\" or \"Microsoft.Storage/storageAccounts\"."
1521+
"description": "The type of the resource."
15221522
},
15231523
"systemData": {
15241524
"$ref": "../../../../../common-types/resource-management/v3/types.json#/definitions/systemData",

0 commit comments

Comments
 (0)