[Communication] - Common - CommunicationCloudEnvironment Fix (#635)

* Rename token to initialToken

* Revert

* Update CommunicationCloudEnvironment

* Address comments

* Address comments

* Address comments

* Address comments

Co-authored-by: Minnie Liu <[email protected]>

Author: minnieliu

sdk/communication/azure-communication-chat/src/main/java/com/azure/android/communication/chat/CommunicationIdentifierSerializer.java

@@ -51,7 +51,7 @@ public static CommunicationIdentifier deserialize(CommunicationIdentifierModel i
             return new MicrosoftTeamsUserIdentifier(teamsUserIdentifierModel.getUserId(),
                 teamsUserIdentifierModel.isAnonymous())
                 .setRawId(rawId)
-                .setCloudEnvironment(new CommunicationCloudEnvironment(teamsUserIdentifierModel.getCloud().toString()));
+                .setCloudEnvironment(CommunicationCloudEnvironment.fromString(teamsUserIdentifierModel.getCloud().toString()));
         }
 
         Objects.requireNonNull(rawId);

sdk/communication/azure-communication-common/src/main/java/com/azure/android/communication/common/CommunicationCloudEnvironment.java

@@ -7,7 +7,7 @@
 /**
  * The cloud that the identifier belongs to.
  */
-public final class CommunicationCloudEnvironment{
+public final class CommunicationCloudEnvironment {
     private static final String PUBLIC_VALUE = "public";
     private static final String DOD_VALUE = "dod";
     private static final String GCCH_VALUE = "gcch";
@@ -23,20 +23,30 @@ public CommunicationCloudEnvironment(String environmentValue) {
         this.environmentValue = environmentValue;
     }
 
+    /**
+     * Sets an environment value from a String
+     * @param environmentValue string representation of the environment value
+     * @return CommunicationCloudEnvironment object itself
+     */
+    public final static CommunicationCloudEnvironment fromString(String environmentValue) {
+        Objects.requireNonNull(environmentValue);
+        return new CommunicationCloudEnvironment(environmentValue);
+    }
+
     /**
      * Represent Azure public cloud
      */
-    public static final CommunicationCloudEnvironment PUBLIC = new CommunicationCloudEnvironment(PUBLIC_VALUE);
+    public static final CommunicationCloudEnvironment PUBLIC = CommunicationCloudEnvironment.fromString(PUBLIC_VALUE);
 
     /**
      * Represent Azure Dod cloud
      */
-    public static final CommunicationCloudEnvironment DOD = new CommunicationCloudEnvironment(DOD_VALUE);
+    public static final CommunicationCloudEnvironment DOD = CommunicationCloudEnvironment.fromString(DOD_VALUE);
 
     /**
      * Represent Azure Gcch cloud
      */
-    public static final CommunicationCloudEnvironment GCCH = new CommunicationCloudEnvironment(GCCH_VALUE);
+    public static final CommunicationCloudEnvironment GCCH = CommunicationCloudEnvironment.fromString(GCCH_VALUE);
 
     @Override
     public boolean equals(Object that) {