[QUERY] httpPipeline.sendSync in AzurePipelinesCredential clientAssertionSupplierWithHttpPipeline #46858
Description
Query/Question
In AzurePipelinesCredential, a sendSync is written for function clientAssertionSupplierWithHttpPipeline
https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/identity/azure-identity/src/main/java/com/azure/identity/AzurePipelinesCredential.java#L73-L80
This clientAssertionSupplierWithHttpPipeline function can be invoked in async IdentityClient
https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/identity/azure-identity/src/main/java/com/azure/identity/implementation/IdentityClient.java#L144-L152
https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/identity/azure-identity/src/main/java/com/azure/identity/implementation/IdentityClientBase.java#L226-L228
Hence, this appears to be a sync I/O invocation in async stack.
Why is this not a Bug or a feature Request?
Not sure if my analysis is correct, not familiar with identity lib.
Example Failure CI
The test code invokes an async API (something of createOrUpdateAsync). And this is a first request to ARM, hence it need to get a token from identity lib.
Setup (please complete the following information if applicable):
- OS: [e.g. iOS]
- IDE: [e.g. IntelliJ]
- Library/Libraries: [e.g. com.azure:azure-identity 1.16.3
Information Checklist
Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report
- Query Added
- Setup information Added