Download function returns SUCCESS after deleting file it should have downloaded. #765
Description
Expected Behavior
File Should be redownloaded if it is already found, but with an invalid hash.
Current Behavior
If the file is found, but the hash can not be validated, the file is deleted and the Download function returns Success
Steps to Reproduce
Look at the code in file extension_manager.cpp line 912
The file is removed if the hash is not valid, OR the file can not be read, because the 'Execute' function changes permissions.
The logic shows that the file is removed. If the file is successfully removed the SUCCESS code is returned in the download function. This is a logic mistake in the file, since is report that the file has been downloaded when it has actually removed the file it was supposed to download.