Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Aug 26, 2025

This PR creates a new branch release/1.14.0-with-pr1552 from the 1.14.0 release tag and cherry-picks the changes from PR #1552 to enable bypassing redirect URL validation for native Edge Browser SSO flows.

Background

PR #1552 was originally merged into the dev branch but was needed for the 1.14.0 release to unblock E2E testing of the native Browser SSO Extension flow on Edge using built-in native DOM APIs. The Broker expects apps to use the redirect URL format msauth.://auth, however MSALJS apps that trigger the native Browser Core SSO Extension flow do not need to follow this format, so redirect URL validation should be bypassed in these scenarios.

Changes Made

The following changes from PR #1552 have been successfully cherry-picked:

  1. Added bypassRedirectURIValidation property to MSIDRequestParameters.h with comprehensive documentation explaining its usage
  2. Added corresponding property to MSIDBrokerOperationTokenRequest.h
  3. Updated property assignment in MSIDBrokerOperationTokenRequest.m to pass the flag through the request pipeline

Files Modified

  • IdentityCore/src/parameters/MSIDRequestParameters.h - Added property with documentation
  • IdentityCore/src/broker_operation/request/token_request/MSIDBrokerOperationTokenRequest.h - Added property declaration
  • IdentityCore/src/broker_operation/request/token_request/MSIDBrokerOperationTokenRequest.m - Added property assignment

Testing

  • Basic compilation validation passed
  • Cherry-pick applied cleanly without conflicts
  • All original commit history and authorship preserved

This change maintains backward compatibility while enabling the necessary flexibility for Edge Browser SSO scenarios in the 1.14.0 release line.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI changed the title [WIP] can create a new branch from release/1.14.0 and cherry pick the change #1552 and merge it Cherry-pick PR #1552: ByPass RedirectUrlValidation for Native Edge Browser SSO flow to release/1.14.0 Aug 26, 2025
Copilot finished work on behalf of swasti29 August 26, 2025 05:47
Copilot AI requested a review from swasti29 August 26, 2025 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants