Skip to content

Commit 70efb25

Browse files
iamgusainsomalaya
andauthored
Changes for Jan 2024 release (#1994)
Changes for Jan 2024 release --------- Co-authored-by: Sowmya Malayanur <[email protected]>
1 parent bf8a944 commit 70efb25

File tree

7 files changed

+10
-15
lines changed

7 files changed

+10
-15
lines changed

changelog

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
MSAL Wiki : https://github.com/AzureAD/microsoft-authentication-library-for-android/wiki
2-
vNext
2+
3+
Version 5.0.0
34
----------
5+
- [MINOR] Update common @17.0.0
46
- [MINOR] Add consumer rule to remove native auth from msal by default (#1986)
57
- [MAJOR] Consuming Credential Manager from common (brings minCompileSdk 34) (#1987)
68

common

Submodule common updated 18 files

msal/build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,7 @@ task sourcesJar(type: Jar) {
188188

189189
// In dev, we want to keep the dependencies (common4j, common) to 1.0.+ to be able to be consumed by daily dev pipeline.
190190
// In release/*, we change these to specific versions being consumed.
191-
String commonVersion = project.hasProperty("distCommonVersion") ? project.distCommonVersion : "1.0.+"
191+
String commonVersion = project.hasProperty("distCommonVersion") ? project.distCommonVersion : "17.0.0"
192192

193193
dependencies {
194194
//Please leave this in... desugaring is currently disabled by default; however it's required for running some tests
@@ -256,7 +256,7 @@ dependencies {
256256
}
257257

258258
testLocalImplementation(testFixtures(project(":common4j")))
259-
String common4jVersion = project.hasProperty("distCommon4jVersion") ? project.distCommon4jVersion : "1.0.+"
259+
String common4jVersion = project.hasProperty("distCommon4jVersion") ? project.distCommon4jVersion : "14.0.0"
260260
testDistImplementation(testFixtures("com.microsoft.identity:common4j:${common4jVersion}"))
261261

262262
implementation platform("io.opentelemetry:opentelemetry-bom:$rootProject.ext.openTelemetryVersion")

msal/versioning/version.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
#Wed Aug 01 15:24:11 PDT 2018
2-
versionName=4.10.0
2+
versionName=5.0.0
33
versionCode=0

msalautomationapp/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
apply plugin: 'com.android.application'
22
apply plugin: 'kotlin-android'
33

4-
def msalVersion = "4.+"
4+
def msalVersion = "5.+"
55

66
if (project.hasProperty("distMsalVersion")) {
77
msalVersion = distMsalVersion

msalautomationapp/src/androidTest/java/com/microsoft/identity/client/msal/automationapp/testpass/broker/brokerapi/TestCase1561652.java

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -104,14 +104,7 @@ public void decodeSSOTokenAndVerifyNonce(@NonNull final String ssoToken,
104104
.append('\n');
105105
}
106106
final String decodedToken = sb.toString();
107-
if (decodedToken.contains("request_nonce")) {
108-
final String[] str = decodedToken.split("request_nonce => ");
109-
if (str.length > 1) {
110-
Assert.assertEquals(str[1].trim(), nonce);
111-
} else {
112-
Assert.fail("decoded token does not contain correct nonce");
113-
}
114-
} else {
107+
if (!decodedToken.contains(nonce)) {
115108
Assert.fail("decoded token does not contain correct nonce");
116109
}
117110
}

testapps/testapp/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525

2626
apply plugin: 'com.android.application'
2727

28-
def msalVersion = "4.+"
28+
def msalVersion = "5.+"
2929

3030
if (project.hasProperty("distMsalVersion")) {
3131
msalVersion = distMsalVersion

0 commit comments

Comments
 (0)