MSAL version 4.6.3 (#1859)

(see
AzureAD/microsoft-authentication-library-common-for-android#2118)

Author: melissaahn

azure-pipelines/pull-request-validation/pr-msal.yml

@@ -93,31 +93,31 @@ jobs:
 #     inputs:
 #       tasks: clean msal:lintLocalDebug
 #       publishJUnitResults: false
-- job: codeql
-  displayName: CodeQL
-  cancelTimeoutInMinutes: 1
-  steps:
-  - checkout: self
-    clean: true
-    submodules: recursive
-    persistCredentials: True
-  - task: CmdLine@1
-    displayName: Set Office MVN Access Token in Environment
-    inputs:
-      filename: echo
-      arguments: '##vso[task.setvariable variable=ENV_VSTS_MVN_ANDROID_MSAL_ACCESSTOKEN]$(System.AccessToken)'
-  - task: Semmle@1
-    inputs:
-      sourceCodeDirectory: '$(Build.SourcesDirectory)'
-      language: 'java'
-      buildCommandsString: 'gradlew.bat clean msal:assembleLocal'
-      querySuite: 'Recommended'
-      timeout: '1800'
-  - task: PublishPipelineArtifact@1
-    displayName: 'Publish code analysis artifacts'
-    inputs:
-      targetPath: '$(Build.SourcesDirectory)\build\outputs\'
-      ArtifactName: 'outputs'
-    condition: failed()
+#- job: codeql
+#  displayName: CodeQL
+#  cancelTimeoutInMinutes: 1
+#  steps:
+#  - checkout: self
+#    clean: true
+#    submodules: recursive
+#    persistCredentials: True
+#  - task: CmdLine@1
+#    displayName: Set Office MVN Access Token in Environment
+#    inputs:
+#      filename: echo
+#      arguments: '##vso[task.setvariable variable=ENV_VSTS_MVN_ANDROID_MSAL_ACCESSTOKEN]$(System.AccessToken)'
+#  - task: Semmle@1
+#    inputs:
+#      sourceCodeDirectory: '$(Build.SourcesDirectory)'
+#      language: 'java'
+#      buildCommandsString: 'gradlew.bat clean msal:assembleLocal'
+#      querySuite: 'Recommended'
+#      timeout: '1800'
+#  - task: PublishPipelineArtifact@1
+#    displayName: 'Publish code analysis artifacts'
+#    inputs:
+#      targetPath: '$(Build.SourcesDirectory)\build\outputs\'
+#      ArtifactName: 'outputs'
+#    condition: failed()
 
 ...

changelog

@@ -1,4 +1,8 @@
 MSAL Wiki : https://github.com/AzureAD/microsoft-authentication-library-for-android/wiki
+Version 4.6.3
+----------
+- [PATCH] Update common @14.0.1
+
 Version 4.6.2
 ----------
 - [PATCH] Wire new Broker Discovery Client into MSAL - still disabled by default (#1835)

common

@@ -187,7 +187,7 @@ task sourcesJar(type: Jar) {
 
 // In dev, we want to keep the dependencies(common4j, broker4j, common) to 0.0.+ to be able to be consumed by daily dev pipeline.
 // In release/*, we change these to specific versions being consumed.
-String commonVersion = project.hasProperty("distCommonVersion") ? project.distCommonVersion : "14.0.0"
+String commonVersion = project.hasProperty("distCommonVersion") ? project.distCommonVersion : "14.0.1"
 
 dependencies {
     //Please leave this in... desugaring is currently disabled by default; however it's required for running some tests

msal/build.gradle

@@ -65,7 +65,6 @@
 import java.util.regex.Pattern;
 
 import static com.microsoft.identity.client.e2e.utils.AcquireTokenTestHelper.getAccount;
-import static com.microsoft.identity.common.java.cache.AbstractAccountCredentialCache.SHA1_APPLICATION_IDENTIFIER_ACCESS_TOKEN_CLEARED;
 import static com.microsoft.identity.internal.testutils.TestConstants.Scopes.USER_READ_SCOPE;
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertFalse;
@@ -297,8 +296,6 @@ public void onError(@NonNull MsalException exception) {
         final IMultiTypeNameValueStorage sharedPreferences = mComponents.getStorageSupplier()
                 .getEncryptedFileStore(SHARED_PREFERENCES_NAME);
         final Map<String, ?> cacheValues = sharedPreferences.getAll();
-        //Getting rid of the SHA-1 cleared flag so it doesn't mess with the assertions below.
-        cacheValues.remove(SHA1_APPLICATION_IDENTIFIER_ACCESS_TOKEN_CLEARED);
 
         assertEquals("Verify number of Cache records (AT, RT, IdToken, AccountRecord) for non removed account",
                 4, cacheValues.size());

msal/src/test/java/com/microsoft/identity/client/e2e/tests/mocked/CrossCloudGuestAccountTest.java

@@ -1,3 +1,3 @@
 #Wed Aug 01 15:24:11 PDT 2018
-versionName=4.6.2
+versionName=4.6.3
 versionCode=0