[Bug] Internal/oauth - bad nil check

[wooffie]

Which version of MSAL Go are you using?
Note that to get help, you need to run the latest version.

v1.4.2

Where is the issue?

• Public client
  • Device code flow
  • Username/Password (ROPC grant)
  • Authorization code flow
• Confidential client
  • Authorization code flow
  • Client credentials:
    • client secret
    • client certificate
• Token cache serialization
  • In-memory cache
• Other (please describe)
  • oauth/wstrust

Is this a new or an existing app?
Just have some code.

Check this part of code -

microsoft-authentication-library-for-go/apps/internal/oauth/ops/wstrust/defs/wstrust_mex_document.go

Line 37 in b4b8bfc

func updateEndpoint(cached *Endpoint, found Endpoint) {

Expected behavior
After check nil we can not write in pointer

Actual behavior
After check nil we can write in pointer

Possible solution
Change checks, I can prepare PR if it is true

[bgavrilMS]

Sorry for the late reply. Go ahead and propose a fix!

What is your scenario here? ROPC (username password) or Integrated Windows Auth?