Skip to content

Conversation

@stefanedwards
Copy link
Contributor

Fixes most of the compiler warnings shown in #170, except for the MongoVectorExtension.

Notes:

  • This fix changes the behaviour of validation errors, as they are now required to have a non-null error message.
  • The "possible null reference" in LoadTableSchema in Extensions/PostgreSQL/PostgresqlDataSinkExtension.cs lines could potentially be entirely resolved by iterating over GetColumnSchema instead of converting to a DataTable.
  • The unit test Invoke_ForTestExtension_ProducesValidSettingsJson appears broken, as the output of the mock-settings are null.
  • Added "-graphBuild:true" to validate.yml workflow, as it appears to help issues mentioned in Workaround to fix VS build hang in certain scenarios #164.

Changes behaviour of validation errors, as they are now required to have a non-null error message.
@markjbrown
Copy link
Collaborator

@stefanedwards this is failing the build test. Can you take a look?

@philnach
Copy link
Collaborator

philnach commented Mar 2, 2025

I fixed the merge and also confirmed that the tests build and run locally, I kicked of the actions to confirm that the actions still pass.

image

@philnach philnach self-requested a review March 2, 2025 21:37
@philnach philnach merged commit 4ff6cd2 into AzureCosmosDB:main Mar 2, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants