ScriptCheckTestBase: compare strlen to 0, not empty string??

afk11 · afk11 · commit 28f08de4e561 · 2021-04-24T02:19:03.000+01:00
diff --git a/tests/Script/ScriptCheckTestBase.php b/tests/Script/ScriptCheckTestBase.php
@@ -128,7 +128,7 @@ public function calcScriptFromString(array $mapOpNames, string $string): ScriptI
                 $item = 'OP_CHECKSEQUENCEVERIFY';
             }
 
-            if (strlen($item) == '') {
+            if (strlen($item) == 0) {
             } else if (preg_match("/^[0-9]*$/", $item) || substr($item, 0, 1) === "-" && preg_match("/^[0-9]*$/", substr($item, 1))) {
                 $builder->int((int) $item);
             } else if (substr($item, 0, 2) === "0x") {

Original file line number	Diff line number	Diff line change
`@@ -128,7 +128,7 @@ public function calcScriptFromString(array $mapOpNames, string $string): ScriptI`
`128`	`128`	`$item = 'OP_CHECKSEQUENCEVERIFY';`
`129`	`129`	`}`
`130`	`130`
`131`		`- if (strlen($item) == '') {`
	`131`	`+ if (strlen($item) == 0) {`
`132`	`132`	`} else if (preg_match("/^[0-9]$/", $item) \|\| substr($item, 0, 1) === "-" && preg_match("/^[0-9]$/", substr($item, 1))) {`
`133`	`133`	`$builder->int((int) $item);`
`134`	`134`	`} else if (substr($item, 0, 2) === "0x") {`