Skip to content

hellovai/beps/exceptions #2759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hellovai merged 22 commits into from
Dec 6, 2025
Merged

hellovai/beps/exceptions #2759

Show file tree
Hide file tree
Changes from 19 commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
9ceed11
Initial research
hellovai Nov 30, 2025
f0cb411
Adding readme
hellovai Dec 1, 2025
75ba816
upate readme
hellovai Dec 1, 2025
7863ce6
add more comparisons (try-catch, go2 proposal)
hellovai Dec 1, 2025
80c29dc
adding ambiguity of open questions
hellovai Dec 1, 2025
2285593
add an updates section on the doc
hellovai Dec 2, 2025
0067ef1
add match statement as well
hellovai Dec 2, 2025
17d376d
update readme
hellovai Dec 2, 2025
62dd494
better ideas for catch
hellovai Dec 3, 2025
0a77b82
update readme
hellovai Dec 3, 2025
dc6877b
add coloring semantics
hellovai Dec 3, 2025
8e92cff
adding story basis
hellovai Dec 3, 2025
967761a
updating beps
hellovai Dec 4, 2025
fee6552
update readme
hellovai Dec 4, 2025
f846bc3
updating statuses
hellovai Dec 4, 2025
9caba6c
improvements to content
hellovai Dec 4, 2025
fda19f5
updated readme
hellovai Dec 4, 2025
3ea9af2
update bep?
hellovai Dec 4, 2025
924d786
improve beps
hellovai Dec 4, 2025
32ad26f
add slack notification
hellovai Dec 4, 2025
9d221e0
fix
hellovai Dec 4, 2025
cd9a6cd
fixes for top level things
hellovai Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 6 additions & 14 deletions .github/workflows/beps.reusable.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,9 @@ jobs:
- uses: actions/checkout@v4
with:
persist-credentials: false
fetch-depth: 0

- name: Fetch base branch history
run: |
git fetch --depth=500 origin canary
- name: Fetch canary ref
Copy link

@cursor cursor bot Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Shallow clone breaks git history lookup in check script

The removal of fetch-depth: 0 from the check-beps job causes a shallow clone (depth 1 by default). The update_bep_readme.py --check script runs git log {canary_ref}..HEAD to determine file modification dates, which requires commit history between canary and HEAD. With a shallow clone, this history is unavailable, causing the script to incorrectly return "TBD" for last_modified dates instead of actual values, leading to potential check failures or inconsistent behavior between CI and local development.

Fix in Cursor Fix in Web

run: git fetch origin canary

- name: Install uv
uses: astral-sh/setup-uv@v5
Expand All @@ -56,9 +54,8 @@ jobs:
persist-credentials: false
fetch-depth: 0

- name: Fetch base branch history
run: |
git fetch --depth=500 origin canary
- name: Fetch canary ref
run: git fetch origin canary

- name: Start deployment
uses: bobheadxi/deployments@v1
Expand Down Expand Up @@ -122,10 +119,6 @@ jobs:
persist-credentials: false
fetch-depth: 0

- name: Fetch base branch history
run: |
git fetch --depth=500 origin canary

- name: Get branch name
id: branch
run: |
Expand All @@ -148,9 +141,8 @@ jobs:
🏗️ **Building BEPs preview...** (run [${{ github.run_id }}](${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}))
comment-tag: beps-preview

- name: Fetch canary branch for diff
run: |
git fetch origin canary:canary || true
- name: Fetch canary ref
run: git fetch origin canary

- name: Setup Python
uses: actions/setup-python@v5
Expand Down
Loading
Loading