fmt: Add BrokenDownTime::set_meridiem
#397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not sure why I didn't add this originally. There is some confusion around what happens when the hour value is inconsistent with the meridiem, but that could already happen when parsing. And in that case, the meridiem takes precedence over the parsed hour value. So we do the same when formatting too. Ref tiffany352/rink-rs#210 (review) PR BurntSushi#397
BurntSushi
force-pushed
the
add-brokendownparts-setmeridiem
branch
from
8a5193f to
48b9d8e
Compare
I think this makes sense. I updated the PR to do exactly this. :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the discussion here: tiffany352/rink-rs#210
set_meridiemseems to have been left out originally because it's not used for formatting. But it is needed for doing custom parsing, so I'm adding it here.Should the meridiem should be used during formatting? The
fmt_hour*functions could be updated to callhour_ranged()instead of reading thehourfield directly.