Skip to content

PLT-1445 Service module adoption for AB2D contracts, events and worker services #1663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jscott-nava wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

PLT-1445 Service module adoption for AB2D contracts, events and worker services #1663

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
61e20e7
Migrating worker service onto CDAP service module.
jscott-nava Dec 17, 2025
0f92fe9
Migrating AB2D contracts to CDAP service module.
jscott-nava Dec 17, 2025
fd045ce
Migrating events service to CDAP service module.
jscott-nava Dec 18, 2025
4c8fe9d
Removing awslogs group and container name overrides.
jscott-nava Jan 7, 2026
e5b6213
Various review feedback updates.
jscott-nava Jan 9, 2026
0b563ea
Various review feedback updates.
jscott-nava Jan 9, 2026
9fe8237
Removing fargate_version to use default 1.4.0.
jscott-nava Jan 14, 2026
94c1b0a
Updating CDAP service module commit hash.
jscott-nava Jan 15, 2026
2415a0d
Adding subnets parameter to service module.
jscott-nava Jan 20, 2026
f2e092b
add new directories for separate contracts and events services
gfreeman-navapbc Feb 4, 2026
562624d
add gate for draft PR on pull request
gfreeman-navapbc Feb 4, 2026
5120b04
update ref in worker
gfreeman-navapbc Feb 4, 2026
de34e08
update to newest service module version
gfreeman-navapbc Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/pull-request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ name: pull request jobs

on:
pull_request:
types: [ready_for_review]
paths-ignore:
- libs/**
- lambdas/**
Expand Down
12 changes: 9 additions & 3 deletions .github/workflows/tofu-apply.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,12 +106,18 @@ jobs:
tofu workspace select -var=parent_env=$ENV -or-create=true $ENV
tofu plan -out=tfplan
tofu apply -input=false tfplan
- name: tofu apply - microservices
working-directory: ops/services/20-microservices/
- name: tofu apply - contracts
working-directory: ops/services/20-contracts/
run: |
tofu init -var=parent_env=$ENV -reconfigure
tofu workspace select -var=parent_env=$ENV -or-create=true $ENV
tofu plan ${{ inputs.contracts_image_tag != '' && format('{0}{1}', '-var=contracts_service_image_tag=', inputs.contracts_image_tag) || '' }} ${{ inputs.events_image_tag != '' && format('{0}{1}', '-var=events_service_image_tag=', inputs.events_image_tag) || '' }} -out=tfplan
tofu plan ${{ inputs.contracts_image_tag != '' && format('{0}{1}', '-var=contracts_service_image_tag=', inputs.contracts_image_tag) || '' }} -out=tfplan
- name: tofu apply - events
working-directory: ops/services/20-events/
run: |
tofu init -var=parent_env=$ENV -reconfigure
tofu workspace select -var=parent_env=$ENV -or-create=true $ENV
tofu plan ${{ inputs.events_image_tag != '' && format('{0}{1}', '-var=events_service_image_tag=', inputs.events_image_tag) || '' }} -out=tfplan
- name: tofu apply - api
working-directory: ops/services/30-api/
run: |
Expand Down
12 changes: 9 additions & 3 deletions .github/workflows/tofu-plan.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,12 +102,18 @@ jobs:
tofu init -var=parent_env=$ENV -reconfigure
tofu workspace select -var=parent_env=$ENV -or-create=true $ENV
tofu plan
- name: tofu plan - microservices
working-directory: ops/services/20-microservices/
- name: tofu plan - contracts
working-directory: ops/services/20-contracts/
run: |
tofu init -var=parent_env=$ENV -reconfigure
tofu workspace select -var=parent_env=$ENV -or-create=true $ENV
tofu plan ${{ inputs.contracts_image_tag != '' && format('{0}{1}', '-var=contracts_service_image_tag=', inputs.contracts_image_tag) || '' }} ${{ inputs.events_image_tag != '' && format('{0}{1}', '-var=events_service_image_tag=', inputs.events_image_tag) || '' }}
tofu plan ${{ inputs.contracts_image_tag != '' && format('{0}{1}', '-var=contracts_service_image_tag=', inputs.contracts_image_tag) || '' }}
- name: tofu plan - events
working-directory: ops/services/20-events/
run: |
tofu init -var=parent_env=$ENV -reconfigure
tofu workspace select -var=parent_env=$ENV -or-create=true $ENV
tofu plan ${{ inputs.events_image_tag != '' && format('{0}{1}', '-var=events_service_image_tag=', inputs.events_image_tag) || '' }}
- name: tofu plan - api
working-directory: ops/services/30-api/
run: |
Expand Down
36 changes: 36 additions & 0 deletions ops/services/20-contracts/data.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
data "aws_sns_topic" "events" {
name = "${local.service_prefix}-events"
}

data "aws_sqs_queue" "events" {
name = "${local.service_prefix}-events"
}

data "aws_security_group" "api" {
name = "${local.service_prefix}-api"
vpc_id = local.vpc_id
}

data "aws_security_group" "worker" {
name = "${local.service_prefix}-worker"
vpc_id = local.vpc_id
}

data "aws_security_group" "lambda" {
name = "${local.service_prefix}-microservices-lambda"
vpc_id = local.vpc_id
}

data "aws_rds_cluster" "this" {
cluster_identifier = local.service_prefix
}

data "aws_iam_role" "task_execution_role" {
name = "${local.service_prefix}-microservices"
}

data "aws_ecr_image" "contracts" {
repository_name = "ab2d-contracts"
image_tag = var.contracts_service_image_tag
most_recent = var.contracts_service_image_tag == null ? true : null
}
Loading