elminate tcp_client_endpoint restart on SubscribeNack #691
+0
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When resuming from suspend-to-ram it's likely that UDP SOME-IP works but the TCP socket got broken. Until a new TCP socket gets established, the remote end responds SubscribeNak. The handler will call restart() restart() will early terminate 5 times total. Thereafter it will call shutdown_and_close_socket_unlocked. This is really expensive if the node sends thousands of total requests before a TCP socket gets established. Options include: 1. do not call restart() at all on SubscribeNak. seems safe? 2. fix restart() to early-terminate better in this state, more than 5x 3. ensure that SOMEIP-SD is inhibited in this state (suspend routing?) This commit implements COVESA#1 but the others might be alternatives
|
Hello, will this modification cause any problems? #690. I explained our problem； we found vsomeip3.5.5 not this modify code!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #690
When resuming from suspend-to-ram it's likely that UDP SOME-IP works but the TCP socket got broken. Until a new TCP socket gets established, the remote end responds SubscribeNak. The handler will call restart()
restart()will early terminate 5 times total. Thereafter it will callshutdown_and_close_socket_unlocked. This is really expensive if the node sends thousands of total requests before a TCP socket gets established.Options include:
restart()at all on SubscribeNak. seems safe?restart()to early-terminate better in this state, more than 5xThis commit implements 1 but the others might be alternatives