fix: Functional bugs in user service ui and backend (#75)

Description
---
This pull request fixes a minor UI bug in the login page and also fixes
a bug in the logic to updating user details.

Author: wzhua02

backend-services/user-backend-service/controller/user-controller.js

@@ -119,35 +119,52 @@ export async function updateUser(req, res) {
     if (!user) {
       return res.status(404).json({ message: `User ${userId} not found` });
     }
-    const username = dirtyUsername ? checkUsername(dirtyUsername) : undefined;
-    const email = dirtyEmail ? checkEmail(dirtyEmail) : undefined;
-    const password = dirtyPassword ? checkPassword(dirtyPassword) : undefined;
 
-    if (username) {
+    let username;
+    if (dirtyUsername) {
+      username = checkUsername(dirtyUsername);
       const existingUser = await _findUserByUsername(username);
       if (existingUser && existingUser.id !== userId) {
         return res.status(409).json({ message: "Username already exists" });
       }
+    } else {
+      username = user.username;
     }
 
-    if (email) {
+    let email;
+    if (dirtyEmail) {
+      email = checkEmail(dirtyEmail);
       const existingUser = await _findUserByEmail(email);
       if (existingUser && existingUser.id !== userId) {
         return res.status(409).json({ message: "Email already exists" });
       }
+    } else {
+      email = user.email;
     }
 
     let hashedPassword;
-    if (password) {
+    if (dirtyPassword) {
+      const unhashedPassword = checkPassword(dirtyPassword);
       const salt = bcrypt.genSaltSync(10);
-      hashedPassword = bcrypt.hashSync(password, salt);
+      hashedPassword = bcrypt.hashSync(unhashedPassword, salt);
+    } else {
+      hashedPassword = user.password;
+    }
+
+    let updatedUser = user;
+    if (
+      !bcrypt.compare(hashedPassword, user.password) ||
+      username !== user.username ||
+      email !== user.email
+    ) {
+      // Only update if there is a change
+      updatedUser = await _updateUserById(
+        userId,
+        username,
+        email,
+        hashedPassword,
+      );
     }
-    const updatedUser = await _updateUserById(
-      userId,
-      username,
-      email,
-      hashedPassword,
-    );
     return res.status(200).json({
       message: `Updated data for user ${userId}`,
       data: formatUserResponse(updatedUser),

ui-services/user-ui-service/src/components/LoginForm.tsx

@@ -93,6 +93,7 @@ const LoginForm: React.FC<LoginFormProps> = ({
           <span className="text-gray-600 text-sm">Remember me</span>
         </label>
         <button
+          type="button"
           onClick={() => {
             onForgotPassword();
           }}