Skip to content

Commit 708445d

Browse files
committed
Merge branch 'master' into fix-collab-voice-issue
# Conflicts: # README.md
2 parents 597eeb5 + 73af252 commit 708445d

File tree

6 files changed

+12
-56
lines changed

6 files changed

+12
-56
lines changed

PeerPrep/src/frontend/pages/Questions.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import { NAV_BUTTONS } from '../config/NavConfig';
1010
import QuestionList from '../components/QuestionList.tsx';
1111
import { useEffect, useMemo, useState } from 'react';
1212
import { questionApi, type QuestionsResponse } from '../api/QuestionApi.tsx';
13-
import {Link, useSearchParams} from 'react-router';
13+
import { Link, useSearchParams } from 'react-router';
1414

1515
const TOTAL_QUESTIONS = 2650;
1616

PeerPrep/src/frontend/pages/auth/Login.tsx

Lines changed: 0 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import React, { useState, useEffect } from 'react';
2-
import GitHubLogo from '../../assets/Images/github-logo.png';
32
import { Link, useNavigate } from 'react-router';
43
import { useAuth } from '../../context/AuthContext';
54

@@ -144,30 +143,6 @@ export default function Login() {
144143
)}
145144
</button>
146145

147-
<div className="divider divider-neutral mt-0">OR</div>
148-
149-
{/* UI to sign in using other platforms */}
150-
{/* Hides Google login btn for now*/}
151-
{/*
152-
<button
153-
type="button"
154-
className="btn btn-primary btn-soft w-full font-normal pb-3"
155-
disabled
156-
>
157-
<img className="h-5 w-5" src={GoogleLogo} alt="Google logo" />
158-
<span className="ml-2">Continue with Google</span>
159-
</button>
160-
*/}
161-
162-
<button
163-
type="button"
164-
className="btn btn-primary btn-soft w-full font-normal mb-3"
165-
disabled // Disable until Github login is set up
166-
>
167-
<img className="h-5 w-5" src={GitHubLogo} alt="GitHub logo" />
168-
<span className="ml-2">Continue with GitHub</span>
169-
</button>
170-
171146
{/* Additional Register Link at Bottom */}
172147
<p className="text-center">
173148
Don't have an account?&nbsp;

PeerPrep/src/frontend/pages/auth/Register.tsx

Lines changed: 0 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import React, { useState } from 'react';
2-
import GitHubLogo from '../../assets/Images/github-logo.png';
32
import { Link } from 'react-router';
43
import { useAuth } from '../../context/AuthContext';
54

@@ -365,30 +364,6 @@ export default function Register() {
365364
)}
366365
</button>
367366

368-
<div className="divider divider-neutral mt-0">OR</div>
369-
370-
{/* UI to sign in using other platforms */}
371-
{/* Hides Google login btn for now*/}
372-
{/*
373-
<button
374-
type="button"
375-
className="btn btn-primary btn-soft w-full font-normal pb-3"
376-
disabled
377-
>
378-
<img className="h-5 w-5" src={GoogleLogo} alt="Google logo" />
379-
<span className="ml-2">Continue with Google</span>
380-
</button>
381-
*/}
382-
383-
<button
384-
type="button"
385-
className="btn btn-primary btn-soft w-full font-normal mb-3"
386-
disabled // Disable until Github login is set up
387-
>
388-
<img className="h-5 w-5" src={GitHubLogo} alt="GitHub logo" />
389-
<span className="ml-2">Register with GitHub</span>
390-
</button>
391-
392367
{/* Additional Register Link at Bottom */}
393368
<p className="text-center">
394369
<Link to="/auth/login" className="underline">

README.md

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,10 @@
66
- You are required to develop individual microservices within separate folders within this repository.
77
- The teaching team should be given access to the repositories as we may require viewing the history of the repository in case of any disputes or disagreements.
88

9-
### Declaration:
10-
- Gavin has adapted server.js inside signaling-svc from node_modules/y-webrtc/bin/server.js and modified it to support audio stream
11-
- Gavin has used ChatGPT to generate debugging logs to VoiceConnectionManager and signaling server
9+
### Acknowledgements:
10+
11+
* `qns-svc/tests/conftest.py` and `qns-hist-svc/tests/conftest.py`:
12+
13+
* Credits to `gxpd-jjh`. Re-used from: https://github.com/tortoise/tortoise-orm/issues/1110#issuecomment-1881967845
14+
* Gavin has adapted `server.js` inside `signaling-svc` from `node_modules/y-webrtc/bin/server.js` and modified it to support audio stream
15+
* Gavin has used ChatGPT to generate debugging logs to VoiceConnectionManager and signaling server

qns-hist-svc/tests/conftest.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,8 @@
88
)
99

1010

11-
# TODO: Acknowledge and credit https://github.com/tortoise/tortoise-orm/issues/1110
11+
# Acknowledgement and credits to gxpd-jjh
12+
# Reused from: https://github.com/tortoise/tortoise-orm/issues/1110#issuecomment-1881967845
1213
@pytest.fixture(scope="module")
1314
def event_loop():
1415
loop = asyncio.get_event_loop_policy().new_event_loop()

qns-svc/tests/conftest.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,8 @@
88
)
99

1010

11-
# TODO: Acknowledge and credit https://github.com/tortoise/tortoise-orm/issues/1110
11+
# Acknowledgement and credits to gxpd-jjh
12+
# Reused from: https://github.com/tortoise/tortoise-orm/issues/1110#issuecomment-1881967845
1213
@pytest.fixture(scope="module")
1314
def event_loop():
1415
loop = asyncio.get_event_loop_policy().new_event_loop()

0 commit comments

Comments
 (0)