Skip to content

Commit ede4b70

Browse files
committed
Add env variable to not use SSL for local instance in collab
1 parent fffad3d commit ede4b70

File tree

4 files changed

+31
-13
lines changed

4 files changed

+31
-13
lines changed

api-gateway/.env.template

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,8 @@ USER_SERVICE_LOGIN_PATH="/us/auth/login"
4444
HEARTBEAT_TTL=300
4545
# Time-to-live (TTL) in seconds for the round-robin counter used in load balancing.
4646
RR_TTL=3600
47+
48+
# To enable redis debugging endpoints, set to DEV
4749
ENVIRONMENT=DEV
4850

4951
# ============================================================================

collaboration-svc/.env.template

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ QUESTION_SERVICE_POOL_URL=
1111
# Question history service register attempt endpoint
1212
QUESTION_SERVICE_HISTORY_URL=
1313

14-
# API Gateway WebSocket Connection
14+
# API Gateway WebSocket Connection (use ws if RUN_TYPE is local, wss otherwise)
1515
GATEWAY_WEBSOCKET_URL=
1616

1717

@@ -20,9 +20,15 @@ APIGATEWAY_URL=http://localhost:8000
2020
REGISTRY_PATH=/registry/register-openapi
2121
HEARTBEAT_PATH=/registry/heartbeat
2222
HEARTBEAT_PERIOD=270
23-
HOST_URL=localhost:8006
23+
HOST_URL=http://localhost:8006
2424
FRONT_END_URL=http://localhost:5173
2525

26+
# To enable redis debugging endpoints, set to DEV
27+
ENVIRONMENT=DEV
28+
29+
# If Run Type is local, skip SSL verification for websocket connection
30+
RUN_TYPE=local
31+
2632
# Logging configuration
2733
LOG_NAME=collaboration-svc
2834
LOG_LEVEL=INFO

collaboration-svc/controllers/websocket_controller.py

Lines changed: 16 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -7,17 +7,18 @@
77
from websockets import ClientConnection
88

99
ENV_API_WEBSOCKET_URL = "GATEWAY_WEBSOCKET_URL"
10+
RUN_TYPE = get_envvar("RUN_TYPE")
1011

1112

1213
class WebSocketManager:
1314
def __init__(self):
1415
self.active_connection = None
15-
16-
# Create SSL context that verifies certificates properly
17-
ssl_context = ssl.create_default_context()
18-
ssl_context.check_hostname = False
19-
ssl_context.verify_mode = ssl.CERT_NONE
20-
self.ssl_context = ssl_context
16+
if RUN_TYPE != "local":
17+
# Create SSL context that verifies certificates properly
18+
ssl_context = ssl.create_default_context()
19+
ssl_context.check_hostname = False
20+
ssl_context.verify_mode = ssl.CERT_NONE
21+
self.ssl_context = ssl_context
2122

2223
def get_websocket_connection(self) -> ClientConnection:
2324
"""
@@ -33,10 +34,15 @@ async def connect(self) -> None:
3334
f"Connecting to API gateway WebSocket at {get_envvar(ENV_API_WEBSOCKET_URL)}"
3435
)
3536
try:
36-
self.active_connection = await websockets.connect(
37-
get_envvar(ENV_API_WEBSOCKET_URL),
38-
ssl=self.ssl_context,
39-
)
37+
if RUN_TYPE != "local":
38+
self.active_connection = await websockets.connect(
39+
get_envvar(ENV_API_WEBSOCKET_URL),
40+
ssl=self.ssl_context,
41+
)
42+
else:
43+
self.active_connection = await websockets.connect(
44+
get_envvar(ENV_API_WEBSOCKET_URL)
45+
)
4046
except Exception:
4147
log.error(
4248
f"Unable to establish a WebSocket connection with API gateway {get_envvar(ENV_API_WEBSOCKET_URL)}"

matching-svc/.env.template

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,13 @@ HEARTBEAT_PATH=/registry/heartbeat
1111
HEARTBEAT_PERIOD=270
1212
HOST_URL=localhost:8005
1313
FRONT_END_URL=http://localhost:5173
14-
ENVIRONMENT=DEV
14+
1515
USER_SERVICE_GET_USER_DETAILS_URL=http://user-svc/users/me
1616

17+
18+
# To enable redis debugging endpoints, set to DEV
19+
ENVIRONMENT=DEV
20+
1721
# Logging configuration
1822
LOG_NAME=matching-svc
1923
LOG_LEVEL=INFO

0 commit comments

Comments
 (0)