Segmentation fault on asyncAggregateWithRandomness

[twoeths]

I tried this in my MacBook aarch64:

it.only("fuzzy test - asyncAggregateWithRandomness", async () => {
      let now = Date.now();
      for (let i = 0; i < 1000; i ++) {
        const {pk, sig} = await asyncAggregateWithRandomness(sets);
        console.log("@@@ finish round ", i);
        expect(verify(msg, pk, sig)).toBeTrue();
      }
      console.log("asyncAggregateWithRandomness", (Date.now() - now) / 1000);
});

sometimes it cause:

test/unit/aggregateWithRandomness.test.ts:
@@@ finish round  0
@@@ finish round  1
@@@ finish round  2
@@@ finish round  3
@@@ finish round  4
@@@ finish round  5
@@@ finish round  6
============================================================
Bun v1.2.5 (013fdddc) macOS Silicon
macOS v15.3.2
Args: "bun" "test" "test/unit/aggregateWithRandomness.test.ts"
Features: jsc tsconfig 
Builtins: "bun:ffi" "node:buffer" "node:crypto" "node:path" "node:string_decoder" "node:util/types" 
Elapsed: 137ms | User: 64ms | Sys: 32ms
RSS: 62.39MB | Peak: 62.39MB | Commit: 1.07GB | Faults: 1516

panic: Segmentation fault at address 0x10
oh no: Bun has crashed. This indicates a bug in Bun, not your code.

To send a redacted crash report to Bun's team,
please file a GitHub issue using the link below:

 https://bun.report/1.2.5/Mt1013fdddEgggQ__+3m+5B+96j6Bu+jm6Bm+t95BulginB2pkinBm/18mB2jwpnBA2AgB

Trace/BPT trap: 5

[twoeths]

sometimes it hangs, it means the callback from zig never return. Need to enforce a timeout at bun side

[twoeths]

closed via #33

[twoeths]

issue happen consistently on MacOS if I run the api in parallel

it.only("fuzzy test - asyncAggregateWithRandomness", async () => {
      let count = 0;
      while (true) {
        const now = Date.now();
        const promises: Promise<{pk: PublicKey; sig: Signature}>[] = [];
        for (let i = 0; i < 1000; i++) {
          promises.push(asyncAggregateWithRandomness(sets));
        }

        try {
          const results = await Promise.all(promises);
          for (const {pk, sig} of results) {
            expect(verify(msg, pk, sig)).toBeTrue();
          }
          console.log("success asyncAggregateWithRandomness", (Date.now() - now) / 1000, count);
        } catch {
          console.log("failed asyncAggregateWithRandomness", (Date.now() - now) / 1000, count);
        }

        count++;
      }

[twoeths]

was able to reproduce the issue even with a very simple function accepting CallbackFn

const CallbackFn = *const fn (result: c_uint) callconv(.C) void;

so that's not an issue of blst-z specifically

with Bun v1.2.10 it said https://bun.sh/docs/api/ffi#experimental-thread-safe-callbacks

Currently, thread-safe callbacks work best when run from another thread that is running JavaScript code, i.e. a [Worker](https://bun.sh/docs/api/workers). A future version of Bun will enable them to be called from any thread (such as new threads spawned by your native library that Bun is not aware of).

so we have to wait for bun to fix this