Skip to content

Commit d26fcf8

Browse files
authored
pass layer & id to https_rule update call (#213)
* pass layer & id to update call * fix tab vs spaces * only fill layer field * fix assignment * set layer w/o check for change * set name only if it was changed * remove ignore-warnings & ignore-errors from https rule destroy * move layer right after uid * get new name w/o checking old
1 parent 29f9b61 commit d26fcf8

File tree

1 file changed

+5
-13
lines changed

1 file changed

+5
-13
lines changed

checkpoint/resource_checkpoint_management_https_rule.go

Lines changed: 5 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -460,16 +460,16 @@ func updateManagementHttpsRule(d *schema.ResourceData, m interface{}) error {
460460
client := m.(*checkpoint.ApiClient)
461461
httpsRule := make(map[string]interface{})
462462

463+
httpsRule["uid"] = d.Id()
464+
465+
httpsRule["layer"] = d.Get("layer")
466+
463467
if ok := d.HasChange("rule_number"); ok {
464468
httpsRule["rule-number"] = d.Get("rule_number")
465469
}
466470

467471
if ok := d.HasChange("name"); ok {
468-
oldName, newName := d.GetChange("name")
469-
httpsRule["name"] = oldName
470-
httpsRule["new-name"] = newName
471-
} else {
472-
httpsRule["name"] = d.Get("name")
472+
httpsRule["new-name"] = d.Get("name")
473473
}
474474

475475
if d.HasChange("destination") {
@@ -608,14 +608,6 @@ func deleteManagementHttpsRule(d *schema.ResourceData, m interface{}) error {
608608
"uid": d.Id(),
609609
"layer": d.Get("layer"),
610610
}
611-
if v, ok := d.GetOkExists("ignore_warnings"); ok {
612-
httpsRulePayload["ignore-warnings"] = v.(bool)
613-
}
614-
615-
if v, ok := d.GetOkExists("ignore_errors"); ok {
616-
httpsRulePayload["ignore-errors"] = v.(bool)
617-
}
618-
log.Println("Delete HttpsRule")
619611

620612
deleteHttpsRuleRes, err := client.ApiCall("delete-https-rule", httpsRulePayload, client.GetSessionID(), true, client.IsProxyUsed())
621613
if err != nil || !deleteHttpsRuleRes.Success {

0 commit comments

Comments
 (0)