Skip to content

Conversation

@Quexington
Copy link
Contributor

Another PR following #18593

@Quexington Quexington requested a review from a team as a code owner September 15, 2025 21:35
@Quexington Quexington added the Changed Required label for PR that categorizes merge commit message as "Changed" for changelog label Sep 15, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2025

This PR has been flagged as stale due to no activity for over 60 days. It will not be automatically closed, but it has been given a stale-pr label and should be manually reviewed by the relevant parties.

@github-actions github-actions bot added the stale-pr Flagged as stale and in need of manual review label Nov 1, 2025
@Quexington Quexington removed the stale-pr Flagged as stale and in need of manual review label Nov 11, 2025
@Quexington Quexington force-pushed the quex.port_cancel_offer_etc_to_marshal branch from d9451ef to 232dd88 Compare November 21, 2025 18:12
@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Nov 21, 2025
Base automatically changed from quex.port_cancel_offer_etc_to_marshal to main November 25, 2025 18:57
@Quexington Quexington force-pushed the quex.port_create_signed_transaction_to_marshal branch from 51ec259 to 041279b Compare November 26, 2025 17:42
@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Nov 26, 2025
@github-actions
Copy link
Contributor

File Coverage Missing Lines
chia/wallet/wallet_request_types.py 97.2% lines 1918
Total Missing Coverage
61 lines Unknown 98%

@coveralls-official
Copy link

Pull Request Test Coverage Report for Build 19713408399

Details

  • 60 of 61 (98.36%) changed or added relevant lines in 4 files are covered.
  • 9 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.006%) to 90.764%

Changes Missing Coverage Covered Lines Changed/Added Lines %
chia/wallet/wallet_request_types.py 35 36 97.22%
Files with Coverage Reduction New Missed Lines %
chia/wallet/wallet_rpc_api.py 1 91.89%
chia/wallet/wallet_node.py 3 86.47%
chia/server/node_discovery.py 5 81.4%
Totals Coverage Status
Change from base Build 19682443433: 0.006%
Covered Lines: 102513
Relevant Lines: 112773

💛 - Coveralls

Copy link
Contributor

@richardkiss richardkiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine.

@TheLastCicada TheLastCicada merged commit f0a141f into main Dec 2, 2025
614 of 617 checks passed
@TheLastCicada TheLastCicada deleted the quex.port_create_signed_transaction_to_marshal branch December 2, 2025 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Changed Required label for PR that categorizes merge commit message as "Changed" for changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants