-
Notifications
You must be signed in to change notification settings - Fork 40
Open
Description
I noticed that in #116 which fixed #57 that
if [ "$ORB_PARAM_REPLACE_EXISTING" == "1" ] && [ "$installed_version" != "$target_version" ]; then was added to 3 of the 4 branches of the install_chrome.sh installation check block.
Darwin, Alpine, yum but not for the else which installs using apt-get (EG debian/ubuntu)
Why was the same change not made in that 4th conditional branch?
Google Chrome 141.0.7390.54 is currently installed; replacing it
Preparing Chrome installation for Debian-based systems
OK
Installing Chrome for AMD64
Get:1 https://download.docker.com/linux/ubuntu focal InRelease [57.7 kB]
Get:2 http://security.ubuntu.com/ubuntu focal-security InRelease [128 kB]
Get:3 http://archive.ubuntu.com/ubuntu focal InRelease [265 kB]
Get:4 http://dl.google.com/linux/chrome/deb stable InRelease [1,825 B]
Get:5 https://download.docker.com/linux/ubuntu focal/stable amd64 Packages [72.3 kB]
Get:7 http://ppa.launchpad.net/git-core/ppa/ubuntu focal InRelease [24.6 kB]
Get:6 https://packagecloud.io/github/git-lfs/ubuntu focal InRelease [29.1 kB]
Get:8 http://ppa.launchpad.net/mozillateam/ppa/ubuntu focal InRelease [24.6 kB]
Get:9 http://archive.ubuntu.com/ubuntu focal-updates InRelease [128 kB]
Get:10 http://security.ubuntu.com/ubuntu focal-security/multiverse amd64 Packages [33.1 kB]
Get:11 http://archive.ubuntu.com/ubuntu focal-backports InRelease [128 kB]
Get:12 http://security.ubuntu.com/ubuntu focal-security/universe amd64 Packages [1,308 kB]
Get:13 http://ppa.launchpad.net/git-core/ppa/ubuntu focal/main amd64 Packages [3,180 B]
Get:14 http://security.ubuntu.com/ubuntu focal-security/main amd64 Packages [4,432 kB]
Get:15 http://dl.google.com/linux/chrome/deb stable/main amd64 Packages [1,206 B]
Get:16 http://archive.ubuntu.com/ubuntu focal/main amd64 Packages [1,275 kB]
Get:18 http://security.ubuntu.com/ubuntu focal-security/restricted amd64 Packages [4,801 kB]
Get:17 https://packagecloud.io/github/git-lfs/ubuntu focal/main amd64 Packages [4,064 B]
Get:19 http://ppa.launchpad.net/mozillateam/ppa/ubuntu focal/main amd64 Packages [43.3 kB]
Get:20 http://archive.ubuntu.com/ubuntu focal/restricted amd64 Packages [33.4 kB]
Get:21 http://archive.ubuntu.com/ubuntu focal/universe amd64 Packages [11.3 MB]
Get:22 http://archive.ubuntu.com/ubuntu focal/multiverse amd64 Packages [177 kB]
Get:23 http://archive.ubuntu.com/ubuntu focal-updates/main amd64 Packages [4,920 kB]
Get:24 http://archive.ubuntu.com/ubuntu focal-updates/universe amd64 Packages [1,599 kB]
Get:25 http://archive.ubuntu.com/ubuntu focal-updates/multiverse amd64 Packages [36.8 kB]
Get:26 http://archive.ubuntu.com/ubuntu focal-updates/restricted amd64 Packages [4,998 kB]
Get:27 http://archive.ubuntu.com/ubuntu focal-backports/main amd64 Packages [55.2 kB]
Get:28 http://archive.ubuntu.com/ubuntu focal-backports/universe amd64 Packages [28.6 kB]
Fetched 35.9 MB in 4s (9,656 kB/s)
Reading package lists... Done
Reading package lists... Done
Building dependency tree
Reading state information... Done
The following packages were automatically installed and are no longer required:
libgmp-dev libgmpxx4ldbl libgnutls-dane0 libgnutls-openssl27 libgnutls28-dev
libgnutlsxx28 libidn2-dev libmariadb3 libp11-kit-dev libtasn1-6-dev
libtasn1-doc libu2f-udev libunbound8 mariadb-common nettle-dev udev
Use 'sudo apt autoremove' to remove them.
The following NEW packages will be installed:
google-chrome-stable
0 upgraded, 1 newly installed, 0 to remove and 234 not upgraded.
Need to get 121 MB of archives.
After this operation, 397 MB of additional disk space will be used.
Get:1 http://dl.google.com/linux/chrome/deb stable/main amd64 google-chrome-stable amd64 141.0.7390.54-1 [121 MB]
Fetched 121 MB in 1s (94.7 MB/s)
debconf: delaying package configuration, since apt-utils is not installed
Selecting previously unselected package google-chrome-stable.
(Reading database ... 46490 files and directories currently installed.)
Preparing to unpack .../google-chrome-stable_141.0.7390.54-1_amd64.deb ...
Unpacking google-chrome-stable (141.0.7390.54-1) ...
Setting up google-chrome-stable (141.0.7390.54-1) ...
update-alternatives: using /usr/bin/google-chrome-stable to provide /usr/bin/x-www-browser (x-www-browser) in auto mode
update-alternatives: using /usr/bin/google-chrome-stable to provide /usr/bin/gnome-www-browser (gnome-www-browser) in auto mode
update-alternatives: using /usr/bin/google-chrome-stable to provide /usr/bin/google-chrome (google-chrome) in auto mode
Processing triggers for mime-support (3.64ubuntu1) ...
Google Chrome 141.0.7390.54 has been installed to /usr/bin/google-chrome-stable
As you can see, the version at the start and end of the install is the same: 141.0.7390.54
Metadata
Metadata
Assignees
Labels
No labels