1385 access port block migration (DCNE-556) #1400
Conversation
…tor, fex_profile. leaf_interface_profile, spine_interface_profile and spine_access_port_selector
…, aci_access_port_selector, aci_fex_profile. aci_leaf_interface_profile, aci_spine_interface_profile and aci_spine_access_port_selector to terrform plugin framework
akinross
requested review from
anvitha-jain,
gmicol,
lhercot,
sajagana,
samiib and
shrsr
as code owners
| relation_to_pc_vpc_override_policy = { | ||
| annotation = "annotation_1" | ||
| target_dn = aci_leaf_access_bundle_policy_sub_group.example.id |
There was a problem hiding this comment.
I don't think this config is valid for spine_access_port_selectors but I suppose you can't skip it based on parent in the example generation right?
There was a problem hiding this comment.
It is correct with teh current resources, the naming of the resource is something we should discuss because aci_leaf_access_bundle_policy_sub_group should pc_vpc_override_policy. I have tested the configuration on APIC.
| legacy: | ||
| port_selector_type: "range" | ||
| ignore_in_legacy: | ||
| - "port_selector_type" |
There was a problem hiding this comment.
you set the value but then ignore it?
There was a problem hiding this comment.
Yes the port_selector_type is provided, which does a look up for the legacy equivalent of it and then sets this in testvars correctly. The ignore_in_legacy is for the new port_selector_type, which is being set through the required part of tests. Since it has multiple named attributes and the naming is being changed ( which we had not done before ). Decided to change this naming to be consistent acroos the 2 selector resources.
| * `parent_dn` - (string) The distinguished name (DN) of the parent object, possible resources: | ||
| - The distinguished name (DN) of classes below can be used but currently there is no available resource for it: | ||
| - [infraInfra](https://pubhub.devnetcloud.com/media/model-doc-latest/docs/app/index.html#/objects/infraInfra/overview) | ||
|
|
||
| - `name` - (Required) The fex profile name. | ||
| - Default: `uni/infra` |
There was a problem hiding this comment.
This is the only value right? Should we hide it?
There was a problem hiding this comment.
This is the only value indeed, and originally this is where I did rn_prepend for, which would in that case remove the parent_dn input completely. In a PR done by Gaspard this was introduced ( suggestion if I recall correctly by you ) to add links to the documentation of the parent object infraInfra.
2 participants
fixes #1385