Skip to content

Commit 4911d77

Browse files
committed
renamed DrawableArray to DrawableStack
1 parent 68ec753 commit 4911d77

File tree

5 files changed

+17
-13
lines changed

5 files changed

+17
-13
lines changed

src/main/java/com/cleanroommc/modularui/api/drawable/IDrawable.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
package com.cleanroommc.modularui.api.drawable;
22

3-
import com.cleanroommc.modularui.drawable.DrawableArray;
3+
import com.cleanroommc.modularui.drawable.DrawableStack;
44
import com.cleanroommc.modularui.drawable.Icon;
55
import com.cleanroommc.modularui.screen.viewport.GuiContext;
66
import com.cleanroommc.modularui.screen.viewport.ModularGuiContext;
@@ -11,7 +11,6 @@
1111
import net.minecraftforge.fml.relauncher.Side;
1212
import net.minecraftforge.fml.relauncher.SideOnly;
1313

14-
import com.google.gson.JsonObject;
1514
import org.jetbrains.annotations.Nullable;
1615

1716
/**
@@ -26,7 +25,7 @@ static IDrawable of(IDrawable... drawables) {
2625
} else if (drawables.length == 1) {
2726
return drawables[0];
2827
} else {
29-
return new DrawableArray(drawables);
28+
return new DrawableStack(drawables);
3029
}
3130
}
3231

@@ -149,7 +148,7 @@ default Icon asIcon() {
149148

150149
static boolean isVisible(@Nullable IDrawable drawable) {
151150
if (drawable == null || drawable == EMPTY || drawable == NONE) return false;
152-
if (drawable instanceof DrawableArray array) {
151+
if (drawable instanceof DrawableStack array) {
153152
return array.getDrawables().length > 0;
154153
}
155154
return true;

src/main/java/com/cleanroommc/modularui/drawable/DrawableSerialization.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ public IDrawable deserialize(JsonElement element, Type typeOfT, JsonDeserializat
9494
if (list.size() == 1) {
9595
return list.get(0);
9696
}
97-
return new DrawableArray(list.toArray(new IDrawable[0]));
97+
return new DrawableStack(list.toArray(new IDrawable[0]));
9898
}
9999
if (!element.isJsonObject()) {
100100
ModularUI.LOGGER.throwing(new JsonParseException("Drawable json should be an object or an array."));
@@ -123,9 +123,9 @@ public IDrawable deserialize(JsonElement element, Type typeOfT, JsonDeserializat
123123
public JsonElement serialize(IDrawable src, Type typeOfSrc, JsonSerializationContext context) {
124124
if (src == IDrawable.EMPTY) return JsonNull.INSTANCE;
125125
if (src == IDrawable.NONE) return new JsonPrimitive("none");
126-
if (src instanceof DrawableArray drawableArray) {
126+
if (src instanceof DrawableStack drawableStack) {
127127
JsonArray jsonArray = new JsonArray();
128-
for (IDrawable drawable : drawableArray.getDrawables()) {
128+
for (IDrawable drawable : drawableStack.getDrawables()) {
129129
jsonArray.add(JsonHelper.serialize(drawable));
130130
}
131131
return jsonArray;

src/main/java/com/cleanroommc/modularui/drawable/DrawableArray.java renamed to src/main/java/com/cleanroommc/modularui/drawable/DrawableStack.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,13 +10,16 @@
1010
import net.minecraftforge.fml.relauncher.Side;
1111
import net.minecraftforge.fml.relauncher.SideOnly;
1212

13-
public class DrawableArray implements IDrawable, IJsonSerializable {
13+
/**
14+
* A stack of {@link IDrawable} backed by an array which are drawn on top of each other.
15+
*/
16+
public class DrawableStack implements IDrawable, IJsonSerializable {
1417

1518
public static final IDrawable[] EMPTY_BACKGROUND = {};
1619

1720
private final IDrawable[] drawables;
1821

19-
public DrawableArray(IDrawable... drawables) {
22+
public DrawableStack(IDrawable... drawables) {
2023
this.drawables = drawables == null || drawables.length == 0 ? EMPTY_BACKGROUND : drawables;
2124
}
2225

src/main/java/com/cleanroommc/modularui/test/TestGuis.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323
import net.minecraft.init.Items;
2424
import net.minecraft.item.ItemStack;
2525
import net.minecraft.util.EnumFacing;
26-
2726
import net.minecraft.util.text.TextFormatting;
2827

2928
import org.jetbrains.annotations.NotNull;
@@ -48,7 +47,10 @@ public class TestGuis extends CustomModularScreen {
4847
.size(20)
4948
.center()
5049
.tooltipBuilder(tooltip -> {
51-
tooltip.addLine("Line 1");
50+
tooltip.addLine("Lorem ipsum dolor sit amet, consetetur sadipscing elitr, sed diam nonumy eirmod tempor invidunt ut labore et dolore magna aliquyam erat, sed diam voluptua. At vero eos et accusam et justo duo dolores et ea rebum. Stet clita kasd gubergren, no sea takimata sanctus est Lorem ipsum dolor sit amet. Lorem ipsum dolor sit amet, consetetur sadipscing elitr, sed diam nonumy eirmod tempor invidunt ut labore et dolore magna aliquyam erat, sed diam voluptua. At vero eos et accusam et justo duo dolores et ea rebum. Stet clita kasd gubergren, no sea takimata sanctus est Lorem ipsum dolor sit amet. Lorem ipsum dolor sit amet, consetetur sadipscing elitr, sed diam nonumy eirmod tempor invidunt ut labore et dolore magna aliquyam erat, sed diam voluptua. At vero eos et accusam et justo duo dolores et ea rebum. Stet clita kasd gubergren, no sea takimata sanctus est Lorem ipsum dolor sit amet. " +
51+
"Duis autem vel eum iriure dolor in hendrerit in vulputate velit esse molestie consequat, vel illum dolore eu feugiat nulla facilisis at vero eros et accumsan et iusto odio dignissim qui blandit praesent luptatum zzril delenit augue duis dolore te feugait nulla facilisi. Lorem ipsum dolor sit amet, consectetuer adipiscing elit, sed diam nonummy nibh euismod tincidunt ut laoreet dolore magna aliquam erat volutpat. " +
52+
"Ut wisi enim ad minim veniam, quis nostrud exerci tation ullamcorper suscipit lobortis nisl ut aliquip ex ea commodo consequat. Duis autem vel eum iriure dolor in hendrerit in vulputate velit esse molestie consequat, vel illum dolore eu feugiat nulla facilisis at vero eros et accumsan et iusto odio dignissim qui blandit praesent luptatum zzril delenit augue duis dolore te feugait nulla facilisi. " +
53+
"Nam liber tempor cum soluta nobis eleifend option congue nihil imperdiet doming id quod mazim placerat facer possim assum. Lorem");
5254
tooltip.addLine("Longer Line 2");
5355
tooltip.addLine("Line 3");
5456
tooltip.alignment(Alignment.Center);

src/main/java/com/cleanroommc/modularui/widgets/PageButton.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
import com.cleanroommc.modularui.api.ITheme;
44
import com.cleanroommc.modularui.api.drawable.IDrawable;
55
import com.cleanroommc.modularui.api.widget.Interactable;
6-
import com.cleanroommc.modularui.drawable.DrawableArray;
6+
import com.cleanroommc.modularui.drawable.DrawableStack;
77
import com.cleanroommc.modularui.drawable.TabTexture;
88
import com.cleanroommc.modularui.theme.WidgetTheme;
99
import com.cleanroommc.modularui.theme.WidgetThemeSelectable;
@@ -58,7 +58,7 @@ public PageButton background(boolean active, IDrawable... background) {
5858
} else if (background.length == 1) {
5959
this.inactiveTexture = background[0];
6060
} else {
61-
this.inactiveTexture = new DrawableArray(background);
61+
this.inactiveTexture = new DrawableStack(background);
6262
}
6363
return this;
6464
}

0 commit comments

Comments
 (0)