-
-
Notifications
You must be signed in to change notification settings - Fork 185
[Fix #119] Implement feature to allow multiple versions of Challenges via git branches #124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Added an extra job in the Detect & Validate Branch :
Added lines in
Updated the |
|
Hey @Zahed-Riyaz, Please resolve the conflicts here? |
|
@RishabhJain2018 I think it's good to go |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Zahed-Riyaz , I think you need to make the change in the backend as well. I don't think we are storing for now which branch is used to create a challenge, since it was always the challenge branch. I think we should also store the branch and repository name (We already store that.)
Also, let's restrict the branch pattern to be challenge-<year>-<versions>. Just in case if someone has multiple versions for a challenge in the same year.
|
Hi @RishabhJain2018 sure I'll check it out and open a PR later. |
9d1ee53 to
164f991
Compare
[Fix #119] This PR implements the feature to allow hosts to create multiple versions of challenges using different git branches.
I tested it by forking the repo with the commits of this PR.
Limitations :