refactor: Improve list building and sorting logic

This commit refactors the list processing logic to improve its safety and efficiency.

The building of the visible list and the mapping of pinned statuses are now performed in a single loop. This avoids potential `IndexOutOfBoundsException` errors that could occur if the sizes of the item list and the pinned status map were mismatched. The sorting logic remains the same but now operates on this more safely constructed list. Additionally, a check to skip duplicate items has been added within the loop.

Author: CreativeCodeCat

app/src/main/java/com/github/droidworksstudio/mlauncher/MainViewModel.kt

@@ -461,22 +461,28 @@ class MainViewModel(application: Application) : AndroidViewModel(application) {
     ): MutableList<R> = withContext(Dispatchers.IO) {
 
         val list = mutableListOf<R>()
+        val pinnedStatusMap = mutableMapOf<R, Boolean>()
         val scrollMap = mutableMapOf<String, Int>()
 
-        // Build the visible list
+        // Build the visible list AND pinned map together (this avoids mismatched sizes)
         items.forEach { raw ->
             val key = getKey(raw)
+
+            // Skip duplicates
             if (!seenKey.add(key)) return@forEach
+
+            // Skip hidden items unless included
             if (isHidden(raw) && !includeHidden) return@forEach
-            list.add(buildItem(raw))
-        }
 
-        // Build a map between built items and their pinned status
-        val pinnedStatusMap = items.zip(list).associate { (item, built) ->
-            built to isPinned(item)
+            // Build the final item
+            val built = buildItem(raw)
+            list.add(built)
+
+            // Map pin state to the built item
+            pinnedStatusMap[built] = isPinned(raw)
         }
 
-        // Sort safely: no index lookups during sorting
+        // Stable, safe sorting — no null comparisons
         list.sortWith(
             compareByDescending<R> { pinnedStatusMap[it] == true }
                 .thenBy { normalize(getLabel(it)) }