Skip to content

Commit 2c5d12f

Browse files
use synchronous .click() in unit tests (#872)
1 parent cbcdcc9 commit 2c5d12f

File tree

3 files changed

+15
-18
lines changed

3 files changed

+15
-18
lines changed

Sprint-3/quote-generator/quotes.test.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ There are some Tests in this file that will help you work out if your code is wo
44

55
const path = require("path");
66
const { JSDOM } = require("jsdom");
7-
const { default: userEvent } = require("@testing-library/user-event");
87

98
let page = null;
109

@@ -61,14 +60,14 @@ describe("Quote generator", () => {
6160
expect(authorP).toHaveTextContent("Albert Einstein");
6261
expect(newQuoteBtn).toHaveTextContent("New quote");
6362

64-
userEvent.click(newQuoteBtn);
63+
newQuoteBtn.click();
6564

6665
expect(quoteP).toHaveTextContent(
6766
"I've learned that people will forget what you said, people will forget what you did, but people will never forget how you made them feel."
6867
);
6968
expect(authorP).toHaveTextContent("Maya Angelou");
7069

71-
userEvent.click(newQuoteBtn);
70+
newQuoteBtn.click();
7271

7372
expect(quoteP).toHaveTextContent(
7473
"I have learned over the years that when one's mind is made up, this diminishes fear."

Sprint-3/reading-list/script.test.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
const path = require("path");
22
const { JSDOM } = require("jsdom");
3-
const { default: userEvent } = require("@testing-library/user-event");
43

54
let page = null;
65

Sprint-3/slideshow/slideshow.test.js

Lines changed: 13 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ There are some Tests in this file that will help you work out if your code is wo
44

55
const path = require("path");
66
const { JSDOM } = require("jsdom");
7-
const { default: userEvent } = require("@testing-library/user-event");
87

98
let page = null;
109

@@ -59,7 +58,7 @@ describe("Level 1 challenge", () => {
5958

6059
expect(image).toHaveAttribute("src", images[0]);
6160

62-
userEvent.click(forwardBtn);
61+
forwardBtn.click();
6362

6463
expect(image).toHaveAttribute("src", images[1]);
6564
});
@@ -73,8 +72,8 @@ describe("Level 1 challenge", () => {
7372
const image = page.window.document.querySelector("#carousel-img");
7473
const forwardBtn = page.window.document.querySelector("#forward-btn");
7574

76-
userEvent.click(forwardBtn);
77-
userEvent.click(forwardBtn);
75+
forwardBtn.click();
76+
forwardBtn.click();
7877

7978
expect(image).toHaveAttribute("src", images[2]);
8079
});
@@ -90,7 +89,7 @@ describe("Level 1 challenge", () => {
9089

9190
expect(image).toHaveAttribute("src", images[0]);
9291

93-
userEvent.click(backwardBtn);
92+
backwardBtn.click();
9493

9594
expect(image).toHaveAttribute("src", images[2]);
9695
});
@@ -105,8 +104,8 @@ describe("Level 1 challenge", () => {
105104
const backwardBtn = page.window.document.querySelector("#backward-btn");
106105
expect(image).toHaveAttribute("src", images[0]);
107106

108-
userEvent.click(backwardBtn);
109-
userEvent.click(backwardBtn);
107+
backwardBtn.click();
108+
backwardBtn.click();
110109

111110
expect(image).toHaveAttribute("src", images[1]);
112111
});
@@ -122,9 +121,9 @@ describe("Level 1 challenge", () => {
122121

123122
expect(image).toHaveAttribute("src", images[0]);
124123

125-
userEvent.click(forwardBtn);
126-
userEvent.click(forwardBtn);
127-
userEvent.click(forwardBtn);
124+
forwardBtn.click();
125+
forwardBtn.click();
126+
forwardBtn.click();
128127

129128
expect(image).toHaveAttribute("src", images[0]);
130129
});
@@ -150,7 +149,7 @@ describe("Level 2 challenge", () => {
150149

151150
expect(image).toHaveAttribute("src", images[0]);
152151

153-
userEvent.click(autoForwardBtn);
152+
autoForwardBtn.click();
154153

155154
expect(autoForwardBtn).toBeDisabled();
156155
expect(autoBackBtn).toBeDisabled();
@@ -177,7 +176,7 @@ describe("Level 2 challenge", () => {
177176

178177
expect(image).toHaveAttribute("src", images[0]);
179178

180-
userEvent.click(autoBackBtn);
179+
autoBackBtn.click();
181180

182181
expect(autoForwardBtn).toBeDisabled();
183182
expect(autoBackBtn).toBeDisabled();
@@ -205,7 +204,7 @@ describe("Level 2 challenge", () => {
205204

206205
expect(image).toHaveAttribute("src", images[0]);
207206

208-
userEvent.click(autoForwardBtn);
207+
autoForwardBtn.click();
209208

210209
expect(autoForwardBtn).toBeDisabled();
211210
expect(autoBackBtn).toBeDisabled();
@@ -216,7 +215,7 @@ describe("Level 2 challenge", () => {
216215
jest.advanceTimersByTime(interval);
217216
expect(image).toHaveAttribute("src", images[2]);
218217

219-
userEvent.click(stopBtn);
218+
stopBtn.click();
220219

221220
expect(autoForwardBtn).toBeEnabled();
222221
expect(autoBackBtn).toBeEnabled();

0 commit comments

Comments
 (0)