[Permissions] Schema checking gives unrelated errors

[Jackenmen]

Command bugs

Command name

[p]permissions acl setglobal/setserver/updateglobal/updateserver

What cog is this command from?

Permissions

What were you expecting to happen?

Either get error about incorrect type of key or have Permissions automatically convert int to str.

What actually happened?

I got error "Top-level keys must be either COG or COMMAND"

How can we reproduce this issue?

1. Create such yaml permissions file:

COMMAND:
  8:
    176070082584248320: true

2. Upload it using one of the commands: [p]permissions acl setglobal/setserver/updateglobal/updateserver
3. See error.

---

The above is reproduction for issue that was already fixed, but the unrelated errors can still happen for yaml file like this:

COMMAND:
  ping:
    default_but_spelt_incorrectly: false

[mikeshardmind]

For anyone currently experiencing this issue:

Wrapping a numeric command in quotes will work fine.

COMMAND:
  "8":
    176070082584248320: true

I'm not sure if we should actually consider this as a bug with permissions, this was intended to catch a mistake like

COMMAND:
  176070082584248320: true

and quoting the command makes sure it was an explicit choice. I think we can be a little more intelligent about it, or at least give a more useful error if/when it occurs so that if it is intentional, people know how to handle it.

[Jackenmen]

The latter example wouldn't be valid because true is not a dict so it should still be possible to differentiate these 2 errors, right?

[mikeshardmind]

We can definitely be smarter about the rror handling here. Just requires someone to update the schema handling for this.

[Jackenmen]

Reopening, apparently the issue with unrelated errors was never fixed, and the related PR only fixed integer commands and empty dict rules - you can still get unrelated error, when you for example spell default wrongly