Skip to content

Relation between Qdark and QtPy PR - avoiding problems #186

@dpizetta

Description

@dpizetta

We use qtpy as an abstraction layer to avoid many files, or tests to be done (It was discussed with @ColinDuquesnoy some time ago).

As seen in branch develop, the code is prettier and clean with this change. Also, I've added qtpy to be imported inside the function, so there is no problem to import qdarkstyle and then set your QT_API variable.

May we need to treat all possible cases to make sure it works correctly, and may some of them should be done in QtPy that will help other users. Also, including tests of importing order to make it more reliable.

This issue is related to my PR QtPy, which also can be a trouble if people import a previous binding directly, then you set another, or if it does not have that one was set. We can discuss more those things directly on QtPy.

Thoughts here @goanpeca ?

Metadata

Metadata

Assignees

Labels

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions