Skip to content

Commit 2c221bd

Browse files
[ci] enable minification in build workflows (#6116)
## Summary Continuation of #6068: set `SHOULD_MINIFY` in build workflows to enable minification. Our build plugin dictates what files are available for extensions to import at runtime: https://github.com/Comfy-Org/ComfyUI_frontend/blob/bfe083dcbad61965b0ef04cf91d06a9cddaca361/build/plugins/comfyAPIPlugin.ts#L52 The shimming marks these files and their named exports and named memebrs as side-effectful, so names should be preserved from the perspective of 3rd party extensions, making this safe in theory. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-6116-ci-enable-minification-in-build-workflows-2906d73d36508141be57f63b619f9f16) by [Unito](https://www.unito.io)
1 parent 76b44d3 commit 2c221bd

File tree

3 files changed

+3
-0
lines changed

3 files changed

+3
-0
lines changed

.github/workflows/publish-desktop-ui.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ jobs:
4444
contents: read
4545
env:
4646
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: '1'
47+
ENABLE_MINIFY: 'true'
4748
steps:
4849
- name: Validate inputs
4950
env:

.github/workflows/release-draft-create.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,7 @@ jobs:
5555
SENTRY_DSN: ${{ secrets.SENTRY_DSN }}
5656
ALGOLIA_APP_ID: ${{ secrets.ALGOLIA_APP_ID }}
5757
ALGOLIA_API_KEY: ${{ secrets.ALGOLIA_API_KEY }}
58+
ENABLE_MINIFY: 'true'
5859
USE_PROD_CONFIG: 'true'
5960
run: |
6061
pnpm install --frozen-lockfile

.github/workflows/release-pypi-dev.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ jobs:
4444
SENTRY_DSN: ${{ secrets.SENTRY_DSN }}
4545
ALGOLIA_APP_ID: ${{ secrets.ALGOLIA_APP_ID }}
4646
ALGOLIA_API_KEY: ${{ secrets.ALGOLIA_API_KEY }}
47+
ENABLE_MINIFY: 'true'
4748
USE_PROD_CONFIG: 'true'
4849
run: |
4950
pnpm install --frozen-lockfile

0 commit comments

Comments
 (0)