Skip to content

Commit b042c21

Browse files
authored
Merge branch 'main' into sno-tidy-workflows
2 parents b719418 + 10af230 commit b042c21

File tree

52 files changed

+324
-394
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

52 files changed

+324
-394
lines changed
-23 Bytes
Loading

browser_tests/tests/graphCanvasMenu.spec.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -39,15 +39,15 @@ test.describe('Graph Canvas Menu', () => {
3939
)
4040
})
4141

42-
test('Focus mode button is clickable and has correct test id', async ({
42+
test('Toggle minimap button is clickable and has correct test id', async ({
4343
comfyPage
4444
}) => {
45-
const focusButton = comfyPage.page.getByTestId('focus-mode-button')
46-
await expect(focusButton).toBeVisible()
47-
await expect(focusButton).toBeEnabled()
45+
const minimapButton = comfyPage.page.getByTestId('toggle-minimap-button')
46+
await expect(minimapButton).toBeVisible()
47+
await expect(minimapButton).toBeEnabled()
4848

4949
// Test that the button can be clicked without error
50-
await focusButton.click()
50+
await minimapButton.click()
5151
await comfyPage.nextFrame()
5252
})
5353

-1.16 KB
Loading
-1.21 KB
Loading

browser_tests/tests/interaction.spec.ts

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,10 @@ import { expect } from '@playwright/test'
33
import type { Position } from '@vueuse/core'
44

55
import {
6-
type ComfyPage,
76
comfyPageFixture as test,
87
testComfySnapToGridGridSize
98
} from '../fixtures/ComfyPage'
9+
import type { ComfyPage } from '../fixtures/ComfyPage'
1010
import type { NodeReference } from '../fixtures/utils/litegraphUtils'
1111

1212
test.beforeEach(async ({ comfyPage }) => {
@@ -786,16 +786,8 @@ test.describe('Viewport settings', () => {
786786
// Screenshot the canvas element
787787
await comfyPage.setSetting('Comfy.Graph.CanvasMenu', true)
788788

789-
// Open zoom controls dropdown first
790-
const zoomControlsButton = comfyPage.page.getByTestId(
791-
'zoom-controls-button'
792-
)
793-
await zoomControlsButton.click()
794-
795789
const toggleButton = comfyPage.page.getByTestId('toggle-minimap-button')
796790
await toggleButton.click()
797-
// close zoom menu
798-
await zoomControlsButton.click()
799791
await comfyPage.setSetting('Comfy.Graph.CanvasMenu', false)
800792

801793
await comfyPage.menu.topbar.saveWorkflow('Workflow A')

browser_tests/tests/minimap.spec.ts

Lines changed: 0 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -35,12 +35,6 @@ test.describe('Minimap', () => {
3535
})
3636

3737
test('Validate minimap toggle button state', async ({ comfyPage }) => {
38-
// Open zoom controls dropdown first
39-
const zoomControlsButton = comfyPage.page.getByTestId(
40-
'zoom-controls-button'
41-
)
42-
await zoomControlsButton.click()
43-
4438
const toggleButton = comfyPage.page.getByTestId('toggle-minimap-button')
4539

4640
await expect(toggleButton).toBeVisible()
@@ -51,13 +45,6 @@ test.describe('Minimap', () => {
5145

5246
test('Validate minimap can be toggled off and on', async ({ comfyPage }) => {
5347
const minimapContainer = comfyPage.page.locator('.litegraph-minimap')
54-
55-
// Open zoom controls dropdown first
56-
const zoomControlsButton = comfyPage.page.getByTestId(
57-
'zoom-controls-button'
58-
)
59-
await zoomControlsButton.click()
60-
6148
const toggleButton = comfyPage.page.getByTestId('toggle-minimap-button')
6249

6350
await expect(minimapContainer).toBeVisible()
@@ -67,22 +54,10 @@ test.describe('Minimap', () => {
6754

6855
await expect(minimapContainer).not.toBeVisible()
6956

70-
// Open zoom controls dropdown again
71-
await zoomControlsButton.click()
72-
await comfyPage.nextFrame()
73-
74-
await expect(toggleButton).toContainText('Show Minimap')
75-
7657
await toggleButton.click()
7758
await comfyPage.nextFrame()
7859

7960
await expect(minimapContainer).toBeVisible()
80-
81-
// Open zoom controls dropdown again to verify button text
82-
await zoomControlsButton.click()
83-
await comfyPage.nextFrame()
84-
85-
await expect(toggleButton).toContainText('Hide Minimap')
8661
})
8762

8863
test('Validate minimap keyboard shortcut Alt+M', async ({ comfyPage }) => {
-29 Bytes
Loading
-86 Bytes
Loading
-121 Bytes
Loading
-49 Bytes
Loading

0 commit comments

Comments
 (0)