Skip to content

Commit b44a395

Browse files
style: remove pulsing animation on executing Vue nodes (#6206)
## Summary Removes pulsing animation which wasn't part of the original design and has performance overhead. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-6206-style-remove-pulsing-animation-on-executing-Vue-nodes-2946d73d3650816ab877da8120ab4085) by [Unito](https://www.unito.io)
1 parent 8e8a45c commit b44a395

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

src/renderer/extensions/vueNodes/components/LGraphNode.vue

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
borderClass,
1919
outlineClass,
2020
{
21-
'animate-pulse': executing,
2221
'before:rounded-2xl before:pointer-events-none before:absolute before:bg-bypass/60 before:inset-0':
2322
bypassed,
2423
'before:rounded-2xl before:pointer-events-none before:absolute before:inset-0':

tests-ui/tests/renderer/extensions/vueNodes/components/LGraphNode.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -197,11 +197,11 @@ describe('LGraphNode', () => {
197197
expect(wrapper.classes()).toContain('outline-node-component-outline')
198198
})
199199

200-
it('should apply executing animation when executing prop is true', () => {
200+
it('should render progress indicator when executing prop is true', () => {
201201
mockData.mockExecuting = true
202202

203203
const wrapper = mountLGraphNode({ nodeData: mockNodeData })
204204

205-
expect(wrapper.classes()).toContain('animate-pulse')
205+
expect(wrapper.classes()).toContain('border-node-stroke-executing')
206206
})
207207
})

0 commit comments

Comments
 (0)