Skip to content

Conversation

@simula-r
Copy link
Contributor

@simula-r simula-r commented Oct 29, 2025

Summary

Banner to try vue nodes. Clicking try it now will flip shouldRenderVueNodes = true.

Screenshots (if applicable)

image

┆Issue is synchronized with this Notion page by Unito

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Oct 29, 2025
@github-actions
Copy link

github-actions bot commented Oct 29, 2025

🎨 Storybook Build Status

Build completed successfully!

⏰ Completed at: 10/30/2025, 04:29:44 AM UTC

🔗 Links


🎉 Your Storybook is ready for review!

@github-actions
Copy link

github-actions bot commented Oct 29, 2025

🎭 Playwright Test Results

⚠️ Tests passed with flaky tests

⏰ Completed at: 10/30/2025, 04:42:20 AM UTC

📈 Summary

  • Total Tests: 499
  • Passed: 466 ✅
  • Failed: 0
  • Flaky: 3 ⚠️
  • Skipped: 30 ⏭️

📊 Test Reports by Browser

  • chromium: View Report • ✅ 457 / ❌ 0 / ⚠️ 3 / ⏭️ 30
  • chromium-2x: View Report • ✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • chromium-0.5x: View Report • ✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • mobile-chrome: View Report • ✅ 6 / ❌ 0 / ⚠️ 0 / ⏭️ 0

🎉 Click on the links above to view detailed test results for each browser configuration.

@github-actions
Copy link

github-actions bot commented Oct 29, 2025

Bundle Size Report

Summary

  • Raw size: 12.3 MB baseline 12.3 MB — 🔴 +2.82 kB
  • Gzip: 2.49 MB baseline 2.49 MB — 🔴 +593 B
  • Brotli: 1.96 MB baseline 1.96 MB — 🔴 +682 B
  • Bundles: 57 current • 57 baseline • 12 added / 12 removed

Category Glance
Graph Workspace 🔴 +2.7 kB (721 kB) · App Entry Points 🔴 +120 B (3.31 MB) · Vendor & Third-Party ⚪ 0 B (5.36 MB) · Other ⚪ 0 B (2.55 MB) · Panels & Settings ⚪ 0 B (294 kB) · UI Components ⚪ 0 B (12.3 kB) · + 3 more

Per-category breakdown
App Entry Points — 3.31 MB (baseline 3.31 MB) • 🔴 +120 B

Main entry bundles and manifests

File Before After Δ Raw Δ Gzip Δ Brotli
assets/index-CQEB0TTx.js (new) 2.69 MB 🔴 +2.69 MB 🔴 +561 kB 🔴 +425 kB
assets/index-C_7RZI3A.js (removed) 2.69 MB 🟢 -2.69 MB 🟢 -561 kB 🟢 -425 kB
assets/index-BtE9DLbG.js (removed) 621 kB 🟢 -621 kB 🟢 -115 kB 🟢 -91 kB
assets/index-BxVP4tuy.js (new) 621 kB 🔴 +621 kB 🔴 +115 kB 🔴 +91.1 kB

Status: 2 added / 2 removed

Graph Workspace — 721 kB (baseline 718 kB) • 🔴 +2.7 kB

Graph editor runtime, canvas, workflow orchestration

File Before After Δ Raw Δ Gzip Δ Brotli
assets/GraphView-oKGZ_Fq7.js (new) 721 kB 🔴 +721 kB 🔴 +141 kB 🔴 +109 kB
assets/GraphView-BxEIQcFs.js (removed) 718 kB 🟢 -718 kB 🟢 -140 kB 🟢 -108 kB

Status: 1 added / 1 removed

Views & Navigation — 8.14 kB (baseline 8.14 kB) • ⚪ 0 B

Top-level views, pages, and routed surfaces

File Before After Δ Raw Δ Gzip Δ Brotli
assets/UserSelectView-DAezPZoS.js (new) 8.14 kB 🔴 +8.14 kB 🔴 +2.47 kB 🔴 +2.16 kB
assets/UserSelectView-i53Ps0bI.js (removed) 8.14 kB 🟢 -8.14 kB 🟢 -2.47 kB 🟢 -2.16 kB

Status: 1 added / 1 removed

Panels & Settings — 294 kB (baseline 294 kB) • ⚪ 0 B

Configuration panels, inspectors, and settings screens

File Before After Δ Raw Δ Gzip Δ Brotli
assets/CreditsPanel-_NPHKncS.js (new) 22 kB 🔴 +22 kB 🔴 +5.28 kB 🔴 +4.62 kB
assets/CreditsPanel-Iyi3ibAF.js (removed) 22 kB 🟢 -22 kB 🟢 -5.28 kB 🟢 -4.61 kB
assets/KeybindingPanel-BHYT-z_7.js (new) 15.2 kB 🔴 +15.2 kB 🔴 +3.77 kB 🔴 +3.31 kB
assets/KeybindingPanel-BIHsrXbR.js (removed) 15.2 kB 🟢 -15.2 kB 🟢 -3.77 kB 🟢 -3.32 kB
assets/ExtensionPanel-D3CxB0gb.js (removed) 12.1 kB 🟢 -12.1 kB 🟢 -2.83 kB 🟢 -2.48 kB
assets/ExtensionPanel-Nw3a3uRr.js (new) 12.1 kB 🔴 +12.1 kB 🔴 +2.83 kB 🔴 +2.48 kB
assets/AboutPanel-B4Z2NBiM.js (new) 10.3 kB 🔴 +10.3 kB 🔴 +2.66 kB 🔴 +2.33 kB
assets/AboutPanel-CrpBXgyJ.js (removed) 10.3 kB 🟢 -10.3 kB 🟢 -2.66 kB 🟢 -2.33 kB
assets/ServerConfigPanel-DYzsm1vA.js (new) 8.2 kB 🔴 +8.2 kB 🔴 +2.16 kB 🔴 +1.9 kB
assets/ServerConfigPanel-URbDB7Ee.js (removed) 8.2 kB 🟢 -8.2 kB 🟢 -2.16 kB 🟢 -1.9 kB
assets/UserPanel-Bg65UiiK.js (new) 7.91 kB 🔴 +7.91 kB 🔴 +2.06 kB 🔴 +1.8 kB
assets/UserPanel-MB6qid11.js (removed) 7.91 kB 🟢 -7.91 kB 🟢 -2.06 kB 🟢 -1.8 kB
assets/settings-B-df0dZe.js 20.7 kB 20.7 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-CI6OKvJn.js 22.9 kB 22.9 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-CXGVj_nD.js 24.5 kB 24.5 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-DfQ6dSJj.js 31.6 kB 31.6 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-DJ2QgDzm.js 25.2 kB 25.2 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-DRNLPMG6.js 23.7 kB 23.7 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-DVVycxDc.js 19.9 kB 19.9 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-G6Dybj1b.js 24.1 kB 24.1 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-M6_GZccG.js 26 kB 26 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B

Status: 6 added / 6 removed

UI Components — 12.3 kB (baseline 12.3 kB) • ⚪ 0 B

Reusable component library chunks

File Before After Δ Raw Δ Gzip Δ Brotli
assets/ComfyQueueButton-CFAaiYFC.js (removed) 11.1 kB 🟢 -11.1 kB 🟢 -2.76 kB 🟢 -2.44 kB
assets/ComfyQueueButton-DASzt7f2.js (new) 11.1 kB 🔴 +11.1 kB 🔴 +2.76 kB 🔴 +2.44 kB
assets/UserAvatar.vue_vue_type_script_setup_true_lang-C9bSkTC5.js 1.12 kB 1.12 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B

Status: 1 added / 1 removed

Data & Services — 10 kB (baseline 10 kB) • ⚪ 0 B

Stores, services, APIs, and repositories

File Before After Δ Raw Δ Gzip Δ Brotli
assets/keybindingService-BRzp3u7T.js (new) 7.21 kB 🔴 +7.21 kB 🔴 +1.75 kB 🔴 +1.5 kB
assets/keybindingService-DmFQzL7i.js (removed) 7.21 kB 🟢 -7.21 kB 🟢 -1.75 kB 🟢 -1.5 kB
assets/serverConfigStore-BRlqNike.js 2.79 kB 2.79 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B

Status: 1 added / 1 removed

Utilities & Hooks — 1.07 kB (baseline 1.07 kB) • ⚪ 0 B

Helpers, composables, and utility bundles

File Before After Δ Raw Δ Gzip Δ Brotli
assets/mathUtil-CTARWQ-l.js 1.07 kB 1.07 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
Vendor & Third-Party — 5.36 MB (baseline 5.36 MB) • ⚪ 0 B

External libraries and shared vendor chunks

File Before After Δ Raw Δ Gzip Δ Brotli
assets/vendor-other-DZSAGrGi.js 3.22 MB 3.22 MB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/vendor-primevue-PESgPnbc.js 517 B 517 B ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/vendor-three-DjRIbjYR.js 1.41 MB 1.41 MB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/vendor-tiptap-VHwWHAra.js 232 kB 232 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/vendor-vue-COj5Gb4q.js 92.4 kB 92.4 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/vendor-xterm-BZLod3g9.js 407 kB 407 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
Other — 2.55 MB (baseline 2.55 MB) • ⚪ 0 B

Bundles that do not match a named category

File Before After Δ Raw Δ Gzip Δ Brotli
assets/commands-B2KZRBmX.js 15.1 kB 15.1 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-Bw-ckyga.js 13.9 kB 13.9 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-C_NmM85I.js 13.8 kB 13.8 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-CuozCW4W.js 14 kB 14 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-DGfVUJCR.js 16.2 kB 16.2 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-dOJNDogK.js 14.5 kB 14.5 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-DwiE551e.js 14.7 kB 14.7 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-Fw7mvqSy.js 13.1 kB 13.1 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-FXnO1W4Q.js 13.2 kB 13.2 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-Bgu6_Hvd.js 59.5 kB 59.5 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-Bv0L0qvp.js 93 kB 93 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-C3Doz3n_.js 67.6 kB 67.6 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-C7eBl607.js 70.7 kB 70.7 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-CHiV9ds2.js 76.4 kB 76.4 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-CIc79Nts.js 68.5 kB 68.5 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-DK5LmuBm.js 58.8 kB 58.8 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-J1nit7cj.js 66.3 kB 66.3 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-W97XgvAQ.js 80.4 kB 80.4 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-8Ef8lY1m.js 196 kB 196 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-BdF8EiZl.js 200 kB 200 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-Bv9Y8Cvp.js 229 kB 229 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-cMdB_wHv.js 179 kB 179 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-CvNWbbtX.js 194 kB 194 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-CwDWxzVz.js 215 kB 215 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-CyPAVHpA.js 191 kB 191 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-D6QTD6bJ.js 181 kB 181 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-DKn6VmRJ.js 192 kB 192 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B

@JorgeR81
Copy link

Are you also planning to have a user setting to switch between vue / litegraph ?

These banners are good for discovering new features, but they can be annoying if they don't show up when we want them to, in order to change the settings.

If you don't want to have a user setting, I would also be happy with a cmd that I can put it in the "run_nvidia_gpu.bat" file.

@simula-r
Copy link
Contributor Author

@JorgeR81
Yes currently you can set a keybind in the settings, search for "vue nodes". It is an experimental feature. A better onboarding and toggle between the 2 modes are coming to ease the on ramp into vue nodes as the future for Comfy. Thanks for your feedback!

@simula-r simula-r force-pushed the feat/vue-nodes-try-it-now-banner branch from efc7a8e to 95bf09f Compare October 29, 2025 18:57
@simula-r simula-r force-pushed the feat/vue-nodes-try-it-now-banner branch from 5f42521 to fd65e98 Compare October 30, 2025 04:01
@simula-r simula-r enabled auto-merge (squash) October 30, 2025 04:43
@christian-byrne christian-byrne merged commit b27c741 into main Oct 30, 2025
27 checks passed
@christian-byrne christian-byrne deleted the feat/vue-nodes-try-it-now-banner branch October 30, 2025 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants