Skip to content

Conversation

@benceruleanlu
Copy link
Member

@benceruleanlu benceruleanlu commented Oct 31, 2025

Summary

  • Add API node usage to run_button_clicked and execution_start telemetry.
  • Include has_api_nodes (boolean) and api_node_names (canonical nodeDef.name array).
  • Compute metrics within a typed reducer for maintainability; stable ordering for names.

Implementation

  • types: src/platform/telemetry/types.ts
    • Extend RunButtonProperties and ExecutionContext with has_api_nodes, api_node_names
  • provider: src/platform/telemetry/providers/cloud/MixpanelTelemetryProvider.ts
    • Build NodeMetrics in single traversal using reduceAllNodes
    • Use canonical names (nodeDef.name), dedupe, sort
    • Emit fields on app:run_button_click and execution_start

Notes

  • Subgraph and total node counts unchanged.
  • Lint and typecheck passed locally.

Requested review

  • Confirm Mixpanel property schema alignment for new fields.
  • Approve naming: has_api_nodes, api_node_names (alternatives: api_node_types).

┆Issue is synchronized with this Notion page by Unito

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Oct 31, 2025
@github-actions
Copy link

github-actions bot commented Oct 31, 2025

🎭 Playwright Test Results

⚠️ Tests passed with flaky tests

⏰ Completed at: 10/31/2025, 03:28:44 AM UTC

📈 Summary

  • Total Tests: 501
  • Passed: 470 ✅
  • Failed: 0
  • Flaky: 1 ⚠️
  • Skipped: 30 ⏭️

📊 Test Reports by Browser

  • chromium: View Report • ✅ 461 / ❌ 0 / ⚠️ 1 / ⏭️ 30
  • chromium-2x: View Report • ✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • chromium-0.5x: View Report • ✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • mobile-chrome: View Report • ✅ 6 / ❌ 0 / ⚠️ 0 / ⏭️ 0

🎉 Click on the links above to view detailed test results for each browser configuration.

@christian-byrne christian-byrne added needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch branch:rh-test labels Oct 31, 2025
@benceruleanlu benceruleanlu removed needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch branch:rh-test labels Oct 31, 2025
@benceruleanlu benceruleanlu merged commit aedf48d into cloud/tracking-v2-add-api-button Oct 31, 2025
32 of 35 checks passed
@benceruleanlu benceruleanlu deleted the feat/telemetry-api-node-details branch October 31, 2025 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants