Merge pull request #1335 from CortexFoundation/dev

ucwong · web-flow · commit 7819a2f4ba8f · 2022-10-21T04:37:03.000+08:00
downloader test fix
diff --git a/ctxc/downloader/downloader_test.go b/ctxc/downloader/downloader_test.go
@@ -722,8 +722,8 @@ func TestBoundedHeavyForkedSync64Full(t *testing.T) { testBoundedHeavyForkedSync
 func TestBoundedHeavyForkedSync64Fast(t *testing.T) { testBoundedHeavyForkedSync(t, 64, FastSync) }
 
 func testBoundedHeavyForkedSync(t *testing.T, protocol int, mode SyncMode) {
-	t.Parallel()
 	tester := newTester()
+	defer tester.terminate()
 
 	// Create a long enough forked chain
 	chainA := testChainForkLightA
@@ -741,7 +741,6 @@ func testBoundedHeavyForkedSync(t *testing.T, protocol int, mode SyncMode) {
 	if err := tester.sync("heavy-rewriter", nil, mode); err != errInvalidAncestor {
 		t.Fatalf("sync failure mismatch: have %v, want %v", err, errInvalidAncestor)
 	}
-	tester.terminate()
 }
 
 // Tests that an inactive downloader will not accept incoming block headers and

Original file line number	Diff line number	Diff line change
`@@ -722,8 +722,8 @@ func TestBoundedHeavyForkedSync64Full(t *testing.T) { testBoundedHeavyForkedSync`
`722`	`722`	`func TestBoundedHeavyForkedSync64Fast(t *testing.T) { testBoundedHeavyForkedSync(t, 64, FastSync) }`
`723`	`723`
`724`	`724`	`func testBoundedHeavyForkedSync(t *testing.T, protocol int, mode SyncMode) {`
`725`		`- t.Parallel()`
`726`	`725`	`tester := newTester()`
	`726`	`+ defer tester.terminate()`
`727`	`727`
`728`	`728`	`// Create a long enough forked chain`
`729`	`729`	`chainA := testChainForkLightA`
`@@ -741,7 +741,6 @@ func testBoundedHeavyForkedSync(t *testing.T, protocol int, mode SyncMode) {`
`741`	`741`	`if err := tester.sync("heavy-rewriter", nil, mode); err != errInvalidAncestor {`
`742`	`742`	`t.Fatalf("sync failure mismatch: have %v, want %v", err, errInvalidAncestor)`
`743`	`743`	`}`
`744`		`- tester.terminate()`
`745`	`744`	`}`
`746`	`745`
`747`	`746`	`// Tests that an inactive downloader will not accept incoming block headers and`